Implement target visibility in GN

tools/gn/target_generator.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/target_generator.h"
 
 #include "tools/gn/action_target_generator.h"
 #include "tools/gn/binary_target_generator.h"
 #include "tools/gn/build_settings.h"
 #include "tools/gn/config.h"
@@ skipping 19 matching lines @@
       function_call_(function_call),
       err_(err) {
 }
 
 TargetGenerator::~TargetGenerator() {
 }
 
 void TargetGenerator::Run() {
   // All target types use these.
   FillDependentConfigs();
+  if (err_->has_error())
+    return;
+
   FillData();
+  if (err_->has_error())
+    return;
+
   FillDependencies();
+  if (err_->has_error())
+    return;
+
+  if (!Visibility::FillItemVisibility(target_, scope_, err_))
+    return;
 
   // Do type-specific generation.
   DoRun();
 }
 
 // static
 void TargetGenerator::GenerateTarget(Scope* scope,
                                      const FunctionCallNode* function_call,
                                      const std::vector<Value>& args,
                                      const std::string& output_type,
@@ skipping 104 matching lines @@
 
   Target::FileList dest_data;
   if (!ExtractListOfRelativeFiles(scope_->settings()->build_settings(), *value,
                                   scope_->GetSourceDir(), &dest_data, err_))
     return;
   target_->data().swap(dest_data);
 }
 
 void TargetGenerator::FillDependencies() {
   FillGenericDeps(variables::kDeps, &target_->deps());
+  if (err_->has_error())
+    return;
   FillGenericDeps(variables::kDatadeps, &target_->datadeps());
+  if (err_->has_error())
+    return;
 
   // This is a list of dependent targets to have their configs fowarded, so
   // it goes here rather than in FillConfigs.
   FillForwardDependentConfigs();
+  if (err_->has_error())
+    return;
 
   FillHardDep();
 }
 
 void TargetGenerator::FillHardDep() {
   const Value* hard_dep_value = scope_->GetValue(variables::kHardDep, true);
   if (!hard_dep_value)
     return;
   if (!hard_dep_value->VerifyTypeIs(Value::BOOLEAN, err_))
     return;
@@ skipping 41 matching lines @@
 
 void TargetGenerator::FillForwardDependentConfigs() {
   const Value* value = scope_->GetValue(
       variables::kForwardDependentConfigsFrom, true);
   if (value) {
     ExtractListOfLabels(*value, scope_->GetSourceDir(),
                         ToolchainLabelForScope(scope_),
                         &target_->forward_dependent_configs(), err_);
   }
 }