tools/gn/functions.cc - Issue 46313003: Implement target visibility in GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/functions.cc

Issue 46313003: Implement target visibility in GN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/functions.cc

diff --git a/tools/gn/functions.cc b/tools/gn/functions.cc

index 393672c2c51a301ffd402a4b741ffc65baf38575..ac1c29492d15be5817f560f9ba02066c1dc99f0e 100644

--- a/tools/gn/functions.cc

+++ b/tools/gn/functions.cc

@@ -233,6 +233,8 @@ Value RunConfig(const FunctionCallNode* function,

// Create the new config.

scoped_ptr<Config> config(new Config(scope->settings(), label));

config->set_defined_from(function);

+ if (!Visibility::FillItemVisibility(config.get(), scope, err))

+ return Value();

// Fill it.

const SourceDir& input_dir = scope->GetSourceDir();

« no previous file with comments | « tools/gn/function_toolchain.cc ('k') | tools/gn/gn.gyp » ('j') | no next file with comments »