Add a parameter GR_ALWAYS_ALLOCATE_ON_HEAP to allow for only ever creating temporary buffers on the…

Add a parameter GR_ALWAYS_ALLOCATE_ON_HEAP to allow for only ever creating temporary buffers on the heap instead of allowing stack allocation

Unfortunately this can't be a GR_GL_* config like we'd discussed because there are SkAutoSMalloc buffers that are built outside of gl/

R=bsalomon
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/b62508be81839be96f3d935d1e568e2ff3663670

[gw, 2014-08-12 05:29:58]

Related bug at Mozilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1051989

[bsalomon, 2014-08-12 13:43:53]

I think there is another one in SkGr.cpp around line 290.

https://codereview.chromium.org/459263003/diff/1/include/gpu/GrConfig.h
File include/gpu/GrConfig.h (right):

https://codereview.chromium.org/459263003/diff/1/include/gpu/GrConfig.h#newco...
include/gpu/GrConfig.h:241: #define GR_ALWAYS_ALLOCATE_ON_HEAP 0
Can you clarify that this is for buffers that will be passed to the 3D API (e.g.
as texture or geometry data).

Indentation seems off on #define (but could just be me, I'm using a browser
extension that sometimes messes up the spacing).

https://codereview.chromium.org/459263003/diff/1/src/gpu/GrTextStrike.cpp
File src/gpu/GrTextStrike.cpp (right):

https://codereview.chromium.org/459263003/diff/1/src/gpu/GrTextStrike.cpp#new...
src/gpu/GrTextStrike.cpp:309: #if GR_ALWAYS_ALLOCATE_ON_HEAP

How about we stick this somewhere:

#if GR_ALWAYS_ALLOCATE_ON_HEAP
    #define GrAutoMallocBaseType SkAutoMalloc
#else
    #define GrAutoMallocBaseTypeSkAutoSMalloc<S>
endif

template <size_t S> GrAutoMalloc : public GrAutoMallocBaseType
{
public:
     GrAutoMalloc(size_t size) : INHERITED(size) {}
private:
     typedef GrAutoMallocBaseType INHERITED;
}

#undef GrMallocBaseType

Would that work?

[bsalomon, 2014-08-13 00:49:59]

lgtm

[gw280, 2014-08-13 00:50:11]

The CQ bit was checked by george@mozilla.com

[commit-bot: I haz the power, 2014-08-13 00:50:53]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/george@mozilla.com/459263003/40001

[commit-bot: I haz the power, 2014-08-13 01:01:04]

Change committed as b62508be81839be96f3d935d1e568e2ff3663670