Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 457473002: Remove the CompositedLayerMappingPtr smart ptr. (Closed)

Created:
6 years, 4 months ago by esprehn
Modified:
6 years, 4 months ago
CC:
abarth-chromium, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, kenneth.christiansen, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove the CompositedLayerMappingPtr smart ptr. All this class did was prevent callers from null pointer checking the object, but all hasCompositedLayerMapping() does is null check it so it's not clear what value this is adding, lets remove it. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179883

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -59 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.h View 2 chunks +5 lines, -4 lines 2 comments Download
M Source/core/rendering/RenderLayer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerModelObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/rendering/compositing/CompositedLayerMappingPtr.h View 1 chunk +0 lines, -39 lines 0 comments Download
M Source/core/rendering/compositing/CompositingLayerAssigner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositingLayerAssigner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/GraphicsLayerUpdater.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/ScrollingCoordinatorChromiumTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
esprehn
6 years, 4 months ago (2014-08-08 04:38:17 UTC) #1
abarth-chromium
LGTM https://codereview.chromium.org/457473002/diff/1/Source/core/rendering/RenderLayer.h File Source/core/rendering/RenderLayer.h (right): https://codereview.chromium.org/457473002/diff/1/Source/core/rendering/RenderLayer.h#newcode318 Source/core/rendering/RenderLayer.h:318: bool hasCompositedLayerMapping() const { return m_compositedLayerMapping.get(); } Shawn's ...
6 years, 4 months ago (2014-08-08 15:34:20 UTC) #2
chrishtr
lgtm https://codereview.chromium.org/457473002/diff/1/Source/core/rendering/RenderLayer.h File Source/core/rendering/RenderLayer.h (right): https://codereview.chromium.org/457473002/diff/1/Source/core/rendering/RenderLayer.h#newcode318 Source/core/rendering/RenderLayer.h:318: bool hasCompositedLayerMapping() const { return m_compositedLayerMapping.get(); } On ...
6 years, 4 months ago (2014-08-08 16:11:42 UTC) #3
esprehn
On 2014/08/08 at 16:11:42, chrishtr wrote: > lgtm > > https://codereview.chromium.org/457473002/diff/1/Source/core/rendering/RenderLayer.h > File Source/core/rendering/RenderLayer.h (right): ...
6 years, 4 months ago (2014-08-09 05:06:23 UTC) #4
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 4 months ago (2014-08-09 05:06:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/457473002/1
6 years, 4 months ago (2014-08-09 05:06:44 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 06:06:13 UTC) #7
Message was sent while issue was closed.
Change committed as 179883

Powered by Google App Engine
This is Rietveld 408576698