Move the user agent styles sheets to blink_resources.grd (Part 2) with Unit test support

Move the user agent styles sheets to blink_resources.grd (Part 2) with Unit test support

Blink should make use of blink_resources.grd for the inline resources of user agent stylesheets.
This removes the dependency upon using make-file-arrays.py which embeds these resources as strings.

This patch adds the necessary plumbing required for the webkit_unit_tests target.
As the resources are being moved into blink_resources.grd, this generates blink_resources.pak.
This pak doesn't exists as a separate pak file but its repacked into "content_shell.pak".
The same must be loaded into the data_pack_ of the TestContentClient so that the webkit (blink) unit
tests run successfully.

Part 1: https://codereview.chromium.org/436843004/
Part 1 with conditional: https://codereview.chromium.org/440683004/
Part 2: https://codereview.chromium.org/422023008
Part 3: https://codereview.chromium.org/438843004/

BUG=312586
Committed: https://crrev.com/4aa5cfbd5b3c15ebe2300e4db14067002b5df18d
Cr-Commit-Position: refs/heads/master@{#294554}

[vivekg, 2014-08-11 12:55:44]

@jochen, this is WIP for moving the core resources to blink_resources.grd file. 

In that, this patch is failing as there is layering violation with respect to
mac specific API: GetResourcesPakFilePath

This API is defined in content/shell/app/paths_mac.h. Should this be part of
base/base_paths_mac.[h,mm]?

[jochen (gone - plz use gerrit), 2014-08-11 14:21:18]

https://codereview.chromium.org/456413002/diff/20001/content/test/test_webkit...
File content/test/test_webkit_platform_support.h (right):

https://codereview.chromium.org/456413002/diff/20001/content/test/test_webkit...
content/test/test_webkit_platform_support.h:103:
scoped_ptr<TestContentClientInitializer> content_initializer_;
i don't think this should happen as part of the webkit platform support

instead, the test fixtures that depend on the resources should have the
initializer

[jochen (gone - plz use gerrit), 2014-08-11 14:24:38]

On 2014/08/11 at 12:55:44, vivekg wrote:
> @jochen, this is WIP for moving the core resources to blink_resources.grd
file. 
> 
> In that, this patch is failing as there is layering violation with respect to
mac specific API: GetResourcesPakFilePath
> 
> This API is defined in content/shell/app/paths_mac.h. Should this be part of
base/base_paths_mac.[h,mm]?

no, it's a content shell specific API.

In fact, it won't work for the other test targets that don't execute content
shell, as it searches for the file in a framework. however, content_unittests is
not using its own framework.

[vivekg, 2014-08-12 07:50:55]

On 2014/08/11 14:21:18, jochen (slow - soon OOO) wrote:
>
https://codereview.chromium.org/456413002/diff/20001/content/test/test_webkit...
> File content/test/test_webkit_platform_support.h (right):
> 
>
https://codereview.chromium.org/456413002/diff/20001/content/test/test_webkit...
> content/test/test_webkit_platform_support.h:103:
> scoped_ptr<TestContentClientInitializer> content_initializer_;
> i don't think this should happen as part of the webkit platform support
> 
> instead, the test fixtures that depend on the resources should have the
> initializer

The resources we are moving with this change are the bare-bones of styling. 
Making them per test would involve changing it a lot of places. Also in future,
the developer need
to make an explicit call to this initializer in his/her test fixture. Hence I
ended up adding this
as part of the TestWebKitPlatformSupport.

> no, it's a content shell specific API.
> 
> In fact, it won't work for the other test targets that don't execute content
> shell, as it searches for the file in a framework. however, content_unittests
is
> not using its own framework.

Is there a way to get the GetResourcesPakFilePath without above API? Sorry I am
not much aware of
Mac environment.

[jochen (gone - plz use gerrit), 2014-08-13 12:52:27]

On 2014/08/12 at 07:50:55, vivekg wrote:
> On 2014/08/11 14:21:18, jochen (slow - soon OOO) wrote:
> >
https://codereview.chromium.org/456413002/diff/20001/content/test/test_webkit...
> > File content/test/test_webkit_platform_support.h (right):
> > 
> >
https://codereview.chromium.org/456413002/diff/20001/content/test/test_webkit...
> > content/test/test_webkit_platform_support.h:103:
> > scoped_ptr<TestContentClientInitializer> content_initializer_;
> > i don't think this should happen as part of the webkit platform support
> > 
> > instead, the test fixtures that depend on the resources should have the
> > initializer
> 
> The resources we are moving with this change are the bare-bones of styling. 
> Making them per test would involve changing it a lot of places. Also in
future, the developer need
> to make an explicit call to this initializer in his/her test fixture. Hence I
ended up adding this
> as part of the TestWebKitPlatformSupport.


I meant the basic test launchers like content/test/content_test_suite.cc

> 
> > no, it's a content shell specific API.
> > 
> > In fact, it won't work for the other test targets that don't execute content
> > shell, as it searches for the file in a framework. however,
content_unittests is
> > not using its own framework.
> 
> Is there a way to get the GetResourcesPakFilePath without above API? Sorry I
am not much aware of
> Mac environment.

For unit tests, it should be enough to do something like this:

base::FilePath path;
PathService::Get(base::DIR_MODULE, &path);
ResourceBundle::GetSharedInstance().AddDataPackFromPath(path,
ui::SCALE_FACTOR_NONE);

[vivekg, 2014-09-02 10:53:55]

Sorry @jochen, I was on a vacation for some time. Uploaded a new patch, PTAL.
Thank you.

[vivekg, 2014-09-03 05:55:32]

ping!

[jochen (gone - plz use gerrit), 2014-09-03 08:26:37]

https://codereview.chromium.org/456413002/diff/40001/content/test/test_conten...
File content/test/test_content_client.cc (right):

https://codereview.chromium.org/456413002/diff/40001/content/test/test_conten...
content/test/test_content_client.cc:27: FILE_PATH_LITERAL("content_shell.pak"));
does this target depend on whatever target creates content_shell.pak?

[vivekg, 2014-09-03 08:55:16]

https://codereview.chromium.org/456413002/diff/40001/content/test/test_conten...
File content/test/test_content_client.cc (right):

https://codereview.chromium.org/456413002/diff/40001/content/test/test_conten...
content/test/test_content_client.cc:27: FILE_PATH_LITERAL("content_shell.pak"));
On 2014/09/03 at 08:26:37, jochen wrote:
> does this target depend on whatever target creates content_shell.pak?

Oh thats a good catch. Its not depending on the content_shell_pak target. I will
add the dep and upload a new patch. Thanks!

[vivekg, 2014-09-04 06:58:26]

Gentle reminder.

[jochen (gone - plz use gerrit), 2014-09-04 08:47:45]

lgtm

[vivekg, 2014-09-04 08:48:22]

On 2014/09/04 at 08:47:45, jochen wrote:
> lgtm

Thank you @jochen.

[vivekg, 2014-09-04 08:48:31]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-09-04 08:50:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/456413002/60001

[commit-bot: I haz the power, 2014-09-04 08:57:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 08:57:59]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[vivekg, 2014-09-04 08:59:11]

The CQ bit was checked by vivekg@chromium.org

[vivekg, 2014-09-04 08:59:49]

The CQ bit was unchecked by vivekg@chromium.org

[jochen (gone - plz use gerrit), 2014-09-04 11:18:42]

still lgtm

[vivekg, 2014-09-04 11:27:50]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-09-04 11:29:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/456413002/80001

[commit-bot: I haz the power, 2014-09-04 12:34:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 12:34:23]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vivekg, 2014-09-04 13:36:06]

On 2014/09/04 at 12:34:23, commit-bot wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

@jochen, this failure seems unrelated to our changes. WDYT?

[eseidel, 2014-09-04 16:22:07]

eseidel@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2014-09-04 16:22:07]

lgtm, but I'm not a content/ OWNER yet.

[vivekg, 2014-09-04 18:40:14]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-09-04 18:40:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/456413002/100001

[vivekg, 2014-09-04 20:12:08]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-09-04 20:13:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/456413002/120001

[commit-bot: I haz the power, 2014-09-04 22:11:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 22:11:58]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[vivekg, 2014-09-05 13:49:05]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-09-05 13:49:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/456413002/120001

[commit-bot: I haz the power, 2014-09-05 16:13:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 16:13:20]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[vivekg, 2014-09-08 11:18:35]

This patch is blocking on the following CLs in the order of dependency:

1. https://codereview.chromium.org/548023002: Migrate ResourceExtractor.java
inside org.chromium.base package.
2. https://codereview.chromium.org/549863002: Include content_shell.pak with the
webkit_unit_tests_apk as internal asset.

[vivekg, 2014-09-12 06:24:50]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-09-12 06:26:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/456413002/180001

[commit-bot: I haz the power, 2014-09-12 06:29:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 06:29:11]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/55112)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/60028)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[vivekg, 2014-09-12 08:02:25]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-09-12 08:03:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/456413002/200001

[commit-bot: I haz the power, 2014-09-12 09:16:45]

Committed patchset #10 (id:200001) as a8c71d1a45b568deab4cd58aea5db6f37e6f4319

[commit-bot: I haz the power, 2014-09-12 09:20:09]

Patchset 10 (id:??) landed as
https://crrev.com/4aa5cfbd5b3c15ebe2300e4db14067002b5df18d
Cr-Commit-Position: refs/heads/master@{#294554}