Migrate ResourceExtractor.java inside org.chromium.base package.

Migrate ResourceExtractor.java inside org.chromium.base package.

With the CL, https://codereview.chromium.org/456413002, we are migrating from embedding inline resources
inside blink towards using chromium's grd resource system. As part of this effort, most of the tests
would require to use the 'pak' files packaged as android application assets.

These assets need to be extracted to the application data directory during the startup of the test
application. The native libraries would be able to work with these 'pak' files only after the extraction
from the asset manager.

To achieve this goal, we would require that ResourceExtractor.java to be moved inside the org.chromium.base
pacakge so that it can be utilized in ChromeNativeTestActivity.java

BUG=312586
Committed: https://crrev.com/e9bb6910f700e0943c157f6802b1ae3793bab221
Cr-Commit-Position: refs/heads/master@{#294548}

[vivekg, 2014-09-06 21:52:29]

vivekg@chromium.org changed reviewers:
+ benm@chromium.org, jdduke@chromium.org, jochen@chromium.org,
tedchoc@chromium.org, vivekg@chromium.org, yfriedman@chromium.org

[vivekg, 2014-09-06 21:52:29]

Adding respective OWNERs for this change, PTAL.

[vivekg, 2014-09-07 07:46:50]

vivekg@chromium.org changed reviewers:
+ mark@chromium.org

[jdduke (slow), 2014-09-08 16:02:13]

On 2014/09/06 21:52:29, vivekg_ wrote:
> Adding respective OWNERs for this change, PTAL.

Rather than adding a bunch of owners and expecting them to sort out who should
review which part of your patch, please be explicit about which file(s) you
would like each owner to review.

[vivekg, 2014-09-08 16:18:23]

On 2014/09/08 16:02:13, jdduke wrote:
> On 2014/09/06 21:52:29, vivekg_ wrote:
> > Adding respective OWNERs for this change, PTAL.
> 
> Rather than adding a bunch of owners and expecting them to sort out who should
> review which part of your patch, please be explicit about which file(s) you
> would like each owner to review.

Yeah sure. 

@tedchoc@chromium.org, @jdduke@chromium.org: 
   base/android/*
   chrome/android/*
   content/public/android/*   
   content/shell/android/*
   ui/android/*

@benm@chromium.org:
   android_webview/*

@brettw@chromium.org:
   base/BUILD.gn

[vivekg, 2014-09-08 16:18:42]

vivekg@chromium.org changed reviewers:
+ brettw@chromium.org
- jochen@chromium.org, mark@chromium.org, yfriedman@chromium.org

[jdduke (slow), 2014-09-08 16:22:40]

On 2014/09/08 16:18:23, vivekg_ wrote:
> On 2014/09/08 16:02:13, jdduke wrote:
> > On 2014/09/06 21:52:29, vivekg_ wrote:
> > > Adding respective OWNERs for this change, PTAL.
> > 
> > Rather than adding a bunch of owners and expecting them to sort out who
should
> > review which part of your patch, please be explicit about which file(s) you
> > would like each owner to review.
> 
> Yeah sure. 
> 
> mailto:@tedchoc@chromium.org, mailto:@jdduke@chromium.org: 
>    base/android/*
>    chrome/android/*
>    content/public/android/*   
>    content/shell/android/*
>    ui/android/*
> 
> mailto:@benm@chromium.org:
>    android_webview/*
> 
> mailto:@brettw@chromium.org:
>    base/BUILD.gn

Thanks. I'm not qualified to review this, and I'm technically only an owner for
input-related changes.

[jdduke (slow), 2014-09-08 16:22:49]

jdduke@chromium.org changed reviewers:
- jdduke@chromium.org

[benm (inactive), 2014-09-08 17:05:00]

https://codereview.chromium.org/548023002/diff/20001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/ResourceExtractor.java (right):

https://codereview.chromium.org/548023002/diff/20001/base/android/java/src/or...
base/android/java/src/org/chromium/base/ResourceExtractor.java:277: public void
collectAllPackagedPakAssets() {
where is this used?

[vivekg, 2014-09-08 17:14:08]

https://codereview.chromium.org/548023002/diff/20001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/ResourceExtractor.java (right):

https://codereview.chromium.org/548023002/diff/20001/base/android/java/src/or...
base/android/java/src/org/chromium/base/ResourceExtractor.java:277: public void
collectAllPackagedPakAssets() {
On 2014/09/08 at 17:05:00, benm wrote:
> where is this used?

This is used here: https://codereview.chromium.org/456413002/patch/160001/170007

Shoud I include the call site changes along with this patch itself?

[benm (inactive), 2014-09-08 17:52:29]

On 2014/09/08 17:14:08, vivekg_ wrote:
>
https://codereview.chromium.org/548023002/diff/20001/base/android/java/src/or...
> File base/android/java/src/org/chromium/base/ResourceExtractor.java (right):
> 
>
https://codereview.chromium.org/548023002/diff/20001/base/android/java/src/or...
> base/android/java/src/org/chromium/base/ResourceExtractor.java:277: public
void
> collectAllPackagedPakAssets() {
> On 2014/09/08 at 17:05:00, benm wrote:
> > where is this used?
> 
> This is used here:
https://codereview.chromium.org/456413002/patch/160001/170007
> 
> Shoud I include the call site changes along with this patch itself?

Yes - either that or move the function addition to the other change. This is
just adding dead code here ;-)

[vivekg, 2014-09-08 18:05:38]

On 2014/09/08 at 17:52:29, benm wrote:
> On 2014/09/08 17:14:08, vivekg_ wrote:
> >
https://codereview.chromium.org/548023002/diff/20001/base/android/java/src/or...
> > File base/android/java/src/org/chromium/base/ResourceExtractor.java (right):
> > 
> >
https://codereview.chromium.org/548023002/diff/20001/base/android/java/src/or...
> > base/android/java/src/org/chromium/base/ResourceExtractor.java:277: public
void
> > collectAllPackagedPakAssets() {
> > On 2014/09/08 at 17:05:00, benm wrote:
> > > where is this used?
> > 
> > This is used here:
https://codereview.chromium.org/456413002/patch/160001/170007
> > 
> > Shoud I include the call site changes along with this patch itself?
> 
> Yes - either that or move the function addition to the other change. This is
just adding dead code here ;-)

Moved the call site changes here in this patch. Clubbing all java changes makes
more sense. Thank you for your feedback. PTAL.

[vivekg, 2014-09-09 14:57:29]

Friendly ping!

[Ted C, 2014-09-09 17:51:00]

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/LocaleUtils.java (right):

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/LocaleUtils.java:18: public static
String getDefaultLocale() {
Why did you need to move this from LocalizationUtils?

Seems exactly the same as the other file.  And it didn't have any native
dependencies before, so this seems unnecessary indirection.

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/ResourceExtractor.java (right):

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/ResourceExtractor.java:277: public void
collectAllPackagedPakAssets() {
I think calling this as:

setExtractAllPaksForTesting

'collect' is a bit confusing to me and it seems like we should keep the naming
the same.

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/ResourceExtractor.java:284:
pakFileAssets.add(file);
braces are always required in java.  You can put statements and conditionals on
the same line if they fit, which it will in this case.

if (file.endsWith(".pak")) pakFileAssets.add(file);

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/ResourceExtractor.java:287:
Log.w(LOGTAG, "Exception while accessing assets: " + e.getMessage());
Use this version instead that takes the exception as the last param:
http://developer.android.com/reference/android/util/Log.html#w(java.lang.String,
java.lang.String, java.lang.Throwable)

[vivekg, 2014-09-09 18:01:31]

Thank you for the review.

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/LocaleUtils.java (right):

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/LocaleUtils.java:18: public static
String getDefaultLocale() {
On 2014/09/09 at 17:51:00, Ted C wrote:
> Why did you need to move this from LocalizationUtils?
> 
> Seems exactly the same as the other file.  And it didn't have any native
dependencies before, so this seems unnecessary indirection.

The reason I moved this is due to its usage in ResourceExtractor.java. 
Keeping the file LocalizationUtils 'as is' in  and calling it from base would
create package dependency on org.chromium.ui.base. Is it ok to have this cross
dependency?

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/ResourceExtractor.java (right):

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/ResourceExtractor.java:277: public void
collectAllPackagedPakAssets() {
On 2014/09/09 at 17:51:00, Ted C wrote:
> I think calling this as:
> 
> setExtractAllPaksForTesting
> 
> 'collect' is a bit confusing to me and it seems like we should keep the naming
the same.

Sure, how about just having extractAllPaksForTesting as we are not setting any
flag(s) to use 'set' as prefix? WDYT?

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/ResourceExtractor.java:284:
pakFileAssets.add(file);
On 2014/09/09 at 17:51:00, Ted C wrote:
> braces are always required in java.  You can put statements and conditionals
on the same line if they fit, which it will in this case.
> 
> if (file.endsWith(".pak")) pakFileAssets.add(file);

Sure, will change. Thank you.

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/ResourceExtractor.java:287:
Log.w(LOGTAG, "Exception while accessing assets: " + e.getMessage());
On 2014/09/09 at 17:51:00, Ted C wrote:
> Use this version instead that takes the exception as the last param:
>
http://developer.android.com/reference/android/util/Log.html#w(java.lang.String,
java.lang.String, java.lang.Throwable)

Sure.

[Ted C, 2014-09-09 18:36:19]

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/LocaleUtils.java (right):

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/LocaleUtils.java:18: public static
String getDefaultLocale() {
On 2014/09/09 18:01:30, vivekg_ wrote:
> On 2014/09/09 at 17:51:00, Ted C wrote:
> > Why did you need to move this from LocalizationUtils?
> > 
> > Seems exactly the same as the other file.  And it didn't have any native
> dependencies before, so this seems unnecessary indirection.
> 
> The reason I moved this is due to its usage in ResourceExtractor.java. 
> Keeping the file LocalizationUtils 'as is' in  and calling it from base would
> create package dependency on org.chromium.ui.base. Is it ok to have this cross
> dependency? 

Ah ha...I missed the ui part of the package.  That definitely is not allowed
(you can check base/DEPS).

This is fine to move then.  Personally, I think we should move more of
LocalizationUtils to this file to make it more the one stop for any Locale
related info on Android.  I don't necessarily think we should do it as part
of this CL, but if you can add a TODO in the other file to make all native
callers depend on this directly instead of the indirect hop it would be good.

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/ResourceExtractor.java (right):

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/ResourceExtractor.java:277: public void
collectAllPackagedPakAssets() {
On 2014/09/09 18:01:31, vivekg_ wrote:
> On 2014/09/09 at 17:51:00, Ted C wrote:
> > I think calling this as:
> > 
> > setExtractAllPaksForTesting
> > 
> > 'collect' is a bit confusing to me and it seems like we should keep the
naming
> the same.
> 
> Sure, how about just having extractAllPaksForTesting as we are not setting any
> flag(s) to use 'set' as prefix? WDYT? 

It is not actually extracting anything though, so I think that is also confusing
since you still need to call startExtractingResources.

[vivekg, 2014-09-09 18:46:32]

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/LocaleUtils.java (right):

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/LocaleUtils.java:18: public static
String getDefaultLocale() {
On 2014/09/09 at 18:36:19, Ted C wrote:
> On 2014/09/09 18:01:30, vivekg_ wrote:
> > On 2014/09/09 at 17:51:00, Ted C wrote:
> This is fine to move then.  Personally, I think we should move more of
> LocalizationUtils to this file to make it more the one stop for any Locale
> related info on Android.  I don't necessarily think we should do it as part
> of this CL, but if you can add a TODO in the other file to make all native
> callers depend on this directly instead of the indirect hop it would be good.

Sure, I will put a TODO there and mostly will make the change in subsequent CL.

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/ResourceExtractor.java (right):

https://codereview.chromium.org/548023002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/ResourceExtractor.java:277: public void
collectAllPackagedPakAssets() {
On 2014/09/09 at 18:36:19, Ted C wrote:
> On 2014/09/09 18:01:31, vivekg_ wrote:
> > On 2014/09/09 at 17:51:00, Ted C wrote:
> It is not actually extracting anything though, so I think that is also
confusing
> since you still need to call startExtractingResources.

Your initial proposal of having the name as 'setExtractAllPacksForTesting'
sounds good then. Will change it.

[vivekg, 2014-09-09 19:23:04]

Uploaded new patch with review comments addressed. PTAL, thanks!

[Ted C, 2014-09-09 23:18:42]

lgtm

https://codereview.chromium.org/548023002/diff/60001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/LocaleUtils.java (right):

https://codereview.chromium.org/548023002/diff/60001/base/android/java/src/or...
base/android/java/src/org/chromium/base/LocaleUtils.java:12: public abstract
class LocaleUtils {
I think for non-instantiatable we typically use the private constructor pattern
instead of the abstract pattern.

https://codereview.chromium.org/548023002/diff/60001/content/shell/android/br...
File
content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java
(right):

https://codereview.chromium.org/548023002/diff/60001/content/shell/android/br...
content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java:13:
* A basic content shell {@link android.app.Application}.
s/shell/browser tests

[vivekg, 2014-09-10 00:46:05]

The CQ bit was checked by vivekg@chromium.org

[vivekg, 2014-09-10 00:47:14]

On 2014/09/09 23:18:42, Ted C wrote:
> lgtm
> 
>
https://codereview.chromium.org/548023002/diff/60001/base/android/java/src/or...
> File base/android/java/src/org/chromium/base/LocaleUtils.java (right):
> 
>
https://codereview.chromium.org/548023002/diff/60001/base/android/java/src/or...
> base/android/java/src/org/chromium/base/LocaleUtils.java:12: public abstract
> class LocaleUtils {
> I think for non-instantiatable we typically use the private constructor
pattern
> instead of the abstract pattern.
> 

Done.

>
https://codereview.chromium.org/548023002/diff/60001/content/shell/android/br...
> File
>
content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java
> (right):
> 
>
https://codereview.chromium.org/548023002/diff/60001/content/shell/android/br...
>
content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java:13:
> * A basic content shell {@link android.app.Application}.
> s/shell/browser tests

Done.

[commit-bot: I haz the power, 2014-09-10 01:09:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/548023002/100001

[vivekg, 2014-09-10 01:19:41]

vivekg@chromium.org changed reviewers:
+ yfriedman@chromium.org
- brettw@chromium.org

[vivekg, 2014-09-10 01:21:55]

Presubmit is failing for missing OWNERs lgtm.

@yfriedman: for base/android/*
@benm: for android_webview/* 

PTAL, thanks!

[Yaron, 2014-09-10 01:33:02]

lgtm

[commit-bot: I haz the power, 2014-09-10 01:49:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 01:49:37]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vivekg, 2014-09-10 01:54:55]

On 2014/09/10 01:49:37, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   android_aosp

Any help about how to make this change land to fix aosp?

[Yaron, 2014-09-10 02:04:07]

Ah, looks like you'll need to fix AOSP and roll it along with your change. See
https://codereview.chromium.org/406023002/ as a recent example. (boliu's lgtm
references the AOSP patch)

[vivekg, 2014-09-10 02:10:44]

On 2014/09/10 02:04:07, Yaron wrote:
> Ah, looks like you'll need to fix AOSP and roll it along with your change. See
> https://codereview.chromium.org/406023002/ as a recent example. (boliu's lgtm
> references the AOSP patch)

Oh sure! There will be some tree redness during the cross repository landing
isn't it? Also can non-googlers submit patch for AOSP?

[Yaron, 2014-09-10 02:25:03]

On 2014/09/10 02:10:44, vivekg_ wrote:
> On 2014/09/10 02:04:07, Yaron wrote:
> > Ah, looks like you'll need to fix AOSP and roll it along with your change.
See
> > https://codereview.chromium.org/406023002/ as a recent example. (boliu's
lgtm
> > references the AOSP patch)
> 
> Oh sure! There will be some tree redness during the cross repository landing
> isn't it? Also can non-googlers submit patch for AOSP?

Yes, Ajith was following through with that but didn't finish the process yet.
Take a look at the comment thread there

[vivekg, 2014-09-10 14:55:01]

On 2014/09/10 at 02:25:03, yfriedman wrote:
> On 2014/09/10 02:10:44, vivekg_ wrote:
> > On 2014/09/10 02:04:07, Yaron wrote:
> > > Ah, looks like you'll need to fix AOSP and roll it along with your change.
See
> > > https://codereview.chromium.org/406023002/ as a recent example. (boliu's
lgtm
> > > references the AOSP patch)
> > 
> > Oh sure! There will be some tree redness during the cross repository landing
> > isn't it? Also can non-googlers submit patch for AOSP?
> 
> Yes, Ajith was following through with that but didn't finish the process yet.
Take a look at the comment thread there

Yeah spoke to Ajith about this. He informed that we need to have separate CLA
for that project to submit the patches.

Can you or boliu help me to land this trivial change [1]? This will help me to
land all the other dependent patches pending for some time now?

[1]
https://gist.githubusercontent.com/anonymous/544121952e6eedb298a6/raw/06d8795...

[vivekg, 2014-09-10 14:55:23]

vivekg@chromium.org changed reviewers:
+ boliu@chromium.org

[Yaron, 2014-09-10 16:55:41]

On 2014/09/10 14:55:01, vivekg_ wrote:
> On 2014/09/10 at 02:25:03, yfriedman wrote:
> > On 2014/09/10 02:10:44, vivekg_ wrote:
> > > On 2014/09/10 02:04:07, Yaron wrote:
> > > > Ah, looks like you'll need to fix AOSP and roll it along with your
change.
> See
> > > > https://codereview.chromium.org/406023002/ as a recent example. (boliu's
> lgtm
> > > > references the AOSP patch)
> > > 
> > > Oh sure! There will be some tree redness during the cross repository
landing
> > > isn't it? Also can non-googlers submit patch for AOSP?
> > 
> > Yes, Ajith was following through with that but didn't finish the process
yet.
> Take a look at the comment thread there
> 
> Yeah spoke to Ajith about this. He informed that we need to have separate CLA
> for that project to submit the patches.
> 
> Can you or boliu help me to land this trivial change [1]? This will help me to
> land all the other dependent patches pending for some time now?
> 
> [1]
>
https://gist.githubusercontent.com/anonymous/544121952e6eedb298a6/raw/06d8795...

I haven't landed anything in AOSP yet and don't have the time to set it up atm,
sorry.
If you want to shortcut the problem, I'd recommend you keep a shim
ResourceExtractor in content and have it extend the one from base. That way the
AOSP reference still works. You should include a TODO to remove the content
version and I'd expect you to circle back when CLA is done.

[boliu, 2014-09-10 16:58:22]

Stop worrying about aosp and fix build failures on other android bots first.
Plus you don't have all the approvals to submit yet to even submit this.

[vivekg, 2014-09-10 17:10:35]

On 2014/09/10 16:58:22, boliu wrote:
> Stop worrying about aosp and fix build failures on other android bots first.
> Plus you don't have all the approvals to submit yet to even submit this.

The bots are failing for the same error in the file
WebViewChromiumFactoryProvider.java.

Sure I will wait for all the necessary lgtm's.

[boliu, 2014-09-10 17:14:03]

On 2014/09/10 17:10:35, vivekg_ wrote:
> On 2014/09/10 16:58:22, boliu wrote:
> > Stop worrying about aosp and fix build failures on other android bots first.
> > Plus you don't have all the approvals to submit yet to even submit this.
> 
> The bots are failing for the same error in the file
> WebViewChromiumFactoryProvider.java.

Interesting. That's something new.

We are mirroring aosp's webview glue layer in third_party, and actually using
that code in regular chrome ninja builds. I'll ask around what
third_party/android_webview_glue is.

> 
> Sure I will wait for all the necessary lgtm's.

[boliu, 2014-09-10 20:24:55]

benm: Did you have more concerns for this change?

[vivekg, 2014-09-11 16:32:34]

@benm, can you please review this and let me know your feedback? Thank you.

[benm (inactive), 2014-09-11 17:15:43]

lgtm

[vivekg, 2014-09-11 17:16:16]

On 2014/09/11 at 17:15:43, benm wrote:
> lgtm

thank you.

[vivekg, 2014-09-11 17:16:26]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-09-11 17:25:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/548023002/100001

[commit-bot: I haz the power, 2014-09-11 18:41:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-11 18:41:08]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[boliu, 2014-09-12 00:07:36]

aosp side uploaded at https://android-review.googlesource.com/107500

[boliu, 2014-09-12 04:35:25]

You need to roll both these things to 60e4952d02f2bfa3f0705043b792c01f79ffbfa6
* frameworks/webview in android_webview/buildbot/aosp_manifest.xml
* third_party/android_webview_glue in DEPS

[vivekg, 2014-09-12 05:04:18]

On 2014/09/12 at 04:35:25, boliu wrote:
> You need to roll both these things to 60e4952d02f2bfa3f0705043b792c01f79ffbfa6
> * frameworks/webview in android_webview/buildbot/aosp_manifest.xml
> * third_party/android_webview_glue in DEPS

@boliu: Thanks a ton for your help. We really appreciate that.

I have updated the patch with the DEPS, PTAL. Thank you.

[boliu, 2014-09-12 05:13:07]

On 2014/09/12 05:04:18, vivekg_ wrote:
> On 2014/09/12 at 04:35:25, boliu wrote:
> > You need to roll both these things to
60e4952d02f2bfa3f0705043b792c01f79ffbfa6
> > * frameworks/webview in android_webview/buildbot/aosp_manifest.xml
> > * third_party/android_webview_glue in DEPS
> 
> @boliu: Thanks a ton for your help. We really appreciate that.
> 
> I have updated the patch with the DEPS, PTAL. Thank you.

lgtm assuming android bots are green

[vivekg, 2014-09-12 05:16:21]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-09-12 05:17:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/548023002/120001

[commit-bot: I haz the power, 2014-09-12 06:17:08]

Committed patchset #7 (id:120001) as 820e3b42b4a66acc22c7a45a059c5495e2539f1d

[commit-bot: I haz the power, 2014-09-12 06:19:07]

Patchset 7 (id:??) landed as
https://crrev.com/e9bb6910f700e0943c157f6802b1ae3793bab221
Cr-Commit-Position: refs/heads/master@{#294548}