Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 549863002: Include content_shell.pak with the webkit_unit_tests_apk as internal asset. (Closed)

Created:
6 years, 3 months ago by vivekg_samsung
Modified:
6 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Include content_shell.pak with the webkit_unit_tests_apk as internal asset. With the CL, https://codereview.chromium.org/456413002, we are migrating from embedding inline resources inside blink towards using chromium's grd resource system. As part of this effort, most of the tests would require to use the 'pak' files packaged as android application assets. These assets need to be extracted to the application data directory during the startup of the test application. The native libraries would be able to work with these 'pak' files only after the extraction from the asset manager. Adding the required 'content_shell.pak' to the target webkit_unit_tests_apk. BUG=312586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/web/web_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
vivekg
PTAL, thank you.
6 years, 3 months ago (2014-09-06 21:42:03 UTC) #3
vivekg
Relevant Java side changes can be found here: https://codereview.chromium.org/548023002
6 years, 3 months ago (2014-09-06 22:04:10 UTC) #4
vivekg
@jochen, any comments on the overall changes required?
6 years, 3 months ago (2014-09-08 11:09:19 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-08 12:02:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/549863002/1
6 years, 3 months ago (2014-09-08 12:03:25 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 13:06:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181556

Powered by Google App Engine
This is Rietveld 408576698