Issue 451153002: Oilpan: Move ConsoleMessage to the heap.

Issue 451153002: Oilpan: Move ConsoleMessage to the heap. (Closed)

Created:
6 years, 4 months ago by sof

Modified:
6 years, 4 months ago

Reviewers:
haraken, oilpan-reviews, kozyatinskiy1, aandrey

CC:
blink-reviews, eustas+blink_chromium.org, caseq+blink_chromium.org, loislo+blink_chromium.org, pfeldman+blink_chromium.org, malch+blink_chromium.org, sof, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, falken, devtools-reviews_chromium.org, kinuko+worker_chromium.org, horo+watch_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: Move ConsoleMessage to the heap. And fix compilation breakage from r179850. TBR=haraken,oilpan-reviews BUG=340522 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179873

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -23 lines)			Patch
M	Source/core/dom/Document.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/frame/FrameConsole.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/frame/FrameConsole.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/frame/LocalDOMWindow.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/ConsoleMessage.h	View	4 chunks	+11 lines, -6 lines	0 comments	Download
M	Source/core/inspector/ConsoleMessage.cpp	View	2 chunks	+11 lines, -2 lines	1 comment	Download
M	Source/core/inspector/InspectorConsoleAgent.cpp	View	4 chunks	+3 lines, -4 lines	0 comments	Download
M	Source/core/inspector/InspectorTimelineAgent.cpp	View	4 chunks	+3 lines, -4 lines	0 comments	Download
M	Source/core/workers/WorkerGlobalScope.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/451153002/1

6 years, 4 months ago (2014-08-08 22:06:00 UTC) #3

haraken

6 years, 4 months ago (2014-08-09 00:31:38 UTC) #5

Message was sent while issue was closed.

LGTM, thanks!

Feel free to ping oilpan-reviews if you find it a pain to fix oilpan builds.

https://codereview.chromium.org/451153002/diff/1/Source/core/inspector/Consol...
File Source/core/inspector/ConsoleMessage.cpp (right):

https://codereview.chromium.org/451153002/diff/1/Source/core/inspector/Consol...
Source/core/inspector/ConsoleMessage.cpp:41:
PassRefPtrWillBeRawPtr<ScriptCallStack> ConsoleMessage::callStack() const

Nit: We normally return a raw pointer from this kind of simple getter, since the
getter is not intending to pass ownership. Not related to this CL though.

Expand Messages | Collapse Messages