Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: Source/core/dom/Document.cpp

Issue 451153002: Oilpan: Move ConsoleMessage to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/FrameConsole.h » ('j') | Source/core/inspector/ConsoleMessage.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index fd82124072de0bad419ae7e1956827102d3c6b6a..6d2a060598458f4b7cd1267c85f963cb2b87bd16 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -5025,7 +5025,7 @@ void Document::internalAddMessage(MessageSource source, MessageLevel level, cons
lineNumber = parser->lineNumber().oneBasedInt();
}
}
- RefPtr<ConsoleMessage> consoleMessage = ConsoleMessage::create(source, level, message, messageURL, lineNumber);
+ RefPtrWillBeRawPtr<ConsoleMessage> consoleMessage = ConsoleMessage::create(source, level, message, messageURL, lineNumber);
consoleMessage->setCallStack(callStack);
consoleMessage->setScriptState(scriptState);
m_frame->console().addMessage(consoleMessage.release());
@@ -5039,7 +5039,7 @@ void Document::addConsoleMessageWithRequestIdentifier(MessageSource source, Mess
}
if (m_frame) {
- RefPtr<ConsoleMessage> consoleMessage = ConsoleMessage::create(source, level, message);
+ RefPtrWillBeRawPtr<ConsoleMessage> consoleMessage = ConsoleMessage::create(source, level, message);
consoleMessage->setRequestIdentifier(requestIdentifier);
m_frame->console().addMessage(consoleMessage.release());
}
« no previous file with comments | « no previous file | Source/core/frame/FrameConsole.h » ('j') | Source/core/inspector/ConsoleMessage.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698