Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: Source/core/frame/FrameConsole.h

Issue 451153002: Oilpan: Move ConsoleMessage to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 13 matching lines...) Expand all
24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */ 27 */
28 28
29 #ifndef FrameConsole_h 29 #ifndef FrameConsole_h
30 #define FrameConsole_h 30 #define FrameConsole_h
31 31
32 #include "bindings/core/v8/ScriptState.h" 32 #include "bindings/core/v8/ScriptState.h"
33 #include "core/frame/ConsoleTypes.h" 33 #include "core/frame/ConsoleTypes.h"
34 #include "platform/heap/Handle.h"
34 #include "wtf/Forward.h" 35 #include "wtf/Forward.h"
35 #include "wtf/PassOwnPtr.h" 36 #include "wtf/PassOwnPtr.h"
36 37
37 namespace blink { 38 namespace blink {
38 39
39 class ConsoleMessage; 40 class ConsoleMessage;
40 class FrameHost; 41 class FrameHost;
41 class ScriptCallStack; 42 class ScriptCallStack;
42 43
43 // FrameConsole takes per-frame console messages and routes them up through the FrameHost to the ChromeClient and Inspector. 44 // FrameConsole takes per-frame console messages and routes them up through the FrameHost to the ChromeClient and Inspector.
44 // It's meant as an abstraction around ChromeClient calls and the way that Blink core/ can add messages to the console. 45 // It's meant as an abstraction around ChromeClient calls and the way that Blink core/ can add messages to the console.
45 class FrameConsole FINAL { 46 class FrameConsole FINAL {
46 public: 47 public:
47 static PassOwnPtr<FrameConsole> create(LocalFrame& frame) { return adoptPtr( new FrameConsole(frame)); } 48 static PassOwnPtr<FrameConsole> create(LocalFrame& frame) { return adoptPtr( new FrameConsole(frame)); }
48 49
49 void addMessage(PassRefPtr<ConsoleMessage>); 50 void addMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>);
50 static String formatStackTraceString(const String& originalMessage, PassRefP trWillBeRawPtr<ScriptCallStack>); 51 static String formatStackTraceString(const String& originalMessage, PassRefP trWillBeRawPtr<ScriptCallStack>);
51 52
52 static void mute(); 53 static void mute();
53 static void unmute(); 54 static void unmute();
54 55
55 private: 56 private:
56 explicit FrameConsole(LocalFrame&); 57 explicit FrameConsole(LocalFrame&);
57 58
58 LocalFrame& m_frame; 59 LocalFrame& m_frame;
59 }; 60 };
60 61
61 } // namespace blink 62 } // namespace blink
62 63
63 #endif // FrameConsole_h 64 #endif // FrameConsole_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698