Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: Source/core/inspector/ConsoleMessage.h

Issue 451153002: Oilpan: Move ConsoleMessage to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ConsoleMessage_h 5 #ifndef ConsoleMessage_h
6 #define ConsoleMessage_h 6 #define ConsoleMessage_h
7 7
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "core/frame/ConsoleTypes.h" 9 #include "core/frame/ConsoleTypes.h"
10 #include "core/inspector/ScriptCallStack.h" 10 #include "core/inspector/ScriptCallStack.h"
11 #include "platform/heap/Handle.h"
11 #include "wtf/Forward.h" 12 #include "wtf/Forward.h"
12 #include "wtf/PassRefPtr.h" 13 #include "wtf/PassRefPtr.h"
13 #include "wtf/RefCounted.h" 14 #include "wtf/RefCounted.h"
14 #include "wtf/text/WTFString.h" 15 #include "wtf/text/WTFString.h"
15 16
16 namespace blink { 17 namespace blink {
17 18
18 class ScriptCallStack; 19 class ScriptCallStack;
19 class ScriptState; 20 class ScriptState;
20 21
21 class ConsoleMessage FINAL: public RefCounted<ConsoleMessage> { 22 class ConsoleMessage FINAL: public RefCountedWillBeGarbageCollectedFinalized<Con soleMessage> {
22 public: 23 public:
23 static PassRefPtr<ConsoleMessage> create(MessageSource source, MessageLevel level, const String& message, const String& url = String(), unsigned lineNumber = 0, unsigned columnNumber = 0) 24 static PassRefPtrWillBeRawPtr<ConsoleMessage> create(MessageSource source, M essageLevel level, const String& message, const String& url = String(), unsigned lineNumber = 0, unsigned columnNumber = 0)
24 { 25 {
25 return adoptRef(new ConsoleMessage(source, level, message, url, lineNumb er, columnNumber)); 26 return adoptRefWillBeNoop(new ConsoleMessage(source, level, message, url , lineNumber, columnNumber));
26 } 27 }
27 28
28 PassRefPtr<ScriptCallStack> callStack() const; 29 ~ConsoleMessage();
29 void setCallStack(PassRefPtr<ScriptCallStack>); 30
31 PassRefPtrWillBeRawPtr<ScriptCallStack> callStack() const;
32 void setCallStack(PassRefPtrWillBeRawPtr<ScriptCallStack>);
30 ScriptState* scriptState() const; 33 ScriptState* scriptState() const;
31 void setScriptState(ScriptState*); 34 void setScriptState(ScriptState*);
32 unsigned long requestIdentifier() const; 35 unsigned long requestIdentifier() const;
33 void setRequestIdentifier(unsigned long); 36 void setRequestIdentifier(unsigned long);
34 const String& url() const; 37 const String& url() const;
35 void setURL(const String&); 38 void setURL(const String&);
36 unsigned lineNumber() const; 39 unsigned lineNumber() const;
37 void setLineNumber(unsigned); 40 void setLineNumber(unsigned);
38 41
39 MessageSource source() const; 42 MessageSource source() const;
40 MessageLevel level() const; 43 MessageLevel level() const;
41 const String& message() const; 44 const String& message() const;
42 unsigned columnNumber() const; 45 unsigned columnNumber() const;
43 46
47 void trace(Visitor*);
48
44 private: 49 private:
45 ConsoleMessage(); 50 ConsoleMessage();
46 ConsoleMessage(MessageSource, MessageLevel, const String& message, const Str ing& url = String(), unsigned lineNumber = 0, unsigned columnNumber = 0); 51 ConsoleMessage(MessageSource, MessageLevel, const String& message, const Str ing& url = String(), unsigned lineNumber = 0, unsigned columnNumber = 0);
47 52
48 MessageSource m_source; 53 MessageSource m_source;
49 MessageLevel m_level; 54 MessageLevel m_level;
50 String m_message; 55 String m_message;
51 String m_url; 56 String m_url;
52 unsigned m_lineNumber; 57 unsigned m_lineNumber;
53 unsigned m_columnNumber; 58 unsigned m_columnNumber;
54 RefPtr<ScriptCallStack> m_callStack; 59 RefPtrWillBeMember<ScriptCallStack> m_callStack;
55 ScriptState* m_scriptState; 60 ScriptState* m_scriptState;
56 unsigned long m_requestIdentifier; 61 unsigned long m_requestIdentifier;
57 }; 62 };
58 63
59 } // namespace WebCore 64 } // namespace WebCore
60 65
61 #endif // ConsoleMessage_h 66 #endif // ConsoleMessage_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698