Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: Source/core/inspector/ConsoleMessage.cpp

Issue 451153002: Oilpan: Move ConsoleMessage to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/ConsoleMessage.h ('k') | Source/core/inspector/InspectorConsoleAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/ConsoleMessage.cpp
diff --git a/Source/core/inspector/ConsoleMessage.cpp b/Source/core/inspector/ConsoleMessage.cpp
index 561b11035d9b194ebe442919941aef10075ebc4c..5b6982c4f831bc22b9906899ac4468f179809477 100644
--- a/Source/core/inspector/ConsoleMessage.cpp
+++ b/Source/core/inspector/ConsoleMessage.cpp
@@ -34,12 +34,16 @@ ConsoleMessage::ConsoleMessage(MessageSource source,
{
}
-PassRefPtr<ScriptCallStack> ConsoleMessage::callStack() const
+ConsoleMessage::~ConsoleMessage()
+{
+}
+
+PassRefPtrWillBeRawPtr<ScriptCallStack> ConsoleMessage::callStack() const
haraken 2014/08/09 00:31:38 Nit: We normally return a raw pointer from this ki
{
return m_callStack;
}
-void ConsoleMessage::setCallStack(PassRefPtr<ScriptCallStack> callStack)
+void ConsoleMessage::setCallStack(PassRefPtrWillBeRawPtr<ScriptCallStack> callStack)
{
m_callStack = callStack;
}
@@ -104,4 +108,9 @@ unsigned ConsoleMessage::columnNumber() const
return m_columnNumber;
}
+void ConsoleMessage::trace(Visitor* visitor)
+{
+ visitor->trace(m_callStack);
+}
+
} // namespace WebCore
« no previous file with comments | « Source/core/inspector/ConsoleMessage.h ('k') | Source/core/inspector/InspectorConsoleAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698