Move string resources to omnibox_strings.grdp

Move string resources to omnibox_strings.grdp

BUG=371538
TEST=build

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290230

[hashimoto, 2014-08-08 09:21:14]

pkasting@: Please review as an owner of autocomplete/
blundell@: Please review as an owner of components/

[blundell, 2014-08-08 13:44:16]

+laforge for the new grdp file

https://codereview.chromium.org/450243002/diff/20001/components/omnibox_strin...
File components/omnibox_strings.grdp (right):

https://codereview.chromium.org/450243002/diff/20001/components/omnibox_strin...
components/omnibox_strings.grdp:4: <message
name="IDS_AUTOCOMPLETE_SEARCH_DESCRIPTION" desc="Description for the default
search match.">
Anthony, do the references to this file need to be added internally before the
file is added in Chromium?

[Peter Kasting, 2014-08-08 17:23:31]

RSLGTM

[hashimoto, 2014-08-12 08:50:26]

laforge@, could you take a look at this change?

[blundell, 2014-08-12 12:37:57]

+karen

lgtm pending Anthony or Karen's response to the question re: adding omnibox.grdp

[hashimoto, 2014-08-13 05:53:46]

Hi Colin,

It seems previously added grdp files were just added without consulting others.

autofill_strings.grdp: https://chromiumcodereview.appspot.com/16983014
bookmarks_strings.grdp: https://codereview.chromium.org/243433002
dom_distiller_strings.grdp: https://chromiumcodereview.appspot.com/23503042
google_strings.grdp: https://codereview.chromium.org/316203003
policy_strings.grdp: https://codereview.chromium.org/85753005
translate_strings.grdp: https://codereview.chromium.org/289993003

Some of these changes were authored or reviewed by you.
How did you proceed when doing this?
Did you do something special when adding these grdp files or something has
changed about our string resource management policy?
Can't we go ahead about this change?

Thanks,
Ryo

[blundell, 2014-08-13 06:30:20]

On 2014/08/13 05:53:46, hashimoto wrote:
> Hi Colin,
> 
> It seems previously added grdp files were just added without consulting
others.
> 
> autofill_strings.grdp: https://chromiumcodereview.appspot.com/16983014
> bookmarks_strings.grdp: https://codereview.chromium.org/243433002
> dom_distiller_strings.grdp: https://chromiumcodereview.appspot.com/23503042
> google_strings.grdp: https://codereview.chromium.org/316203003
> policy_strings.grdp: https://codereview.chromium.org/85753005
> translate_strings.grdp: https://codereview.chromium.org/289993003
> 
> Some of these changes were authored or reviewed by you.
> How did you proceed when doing this?

I didn't know at that time that there were internal changes that needed to be
made when adding a grdp file. The result was that components strings were not
translated until someone posted a bug and we tracked down what was going on.
This CL is the first grdp file addition that I'm involved in since that debacle,
hence my not knowing exactly what the right procedure is.

> Did you do something special when adding these grdp files or something has
> changed about our string resource management policy?
> Can't we go ahead about this change?

We can't go ahead as-is, as these omnibox strings will end up untranslated.

> 
> Thanks,
> Ryo

[hashimoto, 2014-08-18 05:37:45]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-08-18 05:38:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/450243002/20001

[commit-bot: I haz the power, 2014-08-18 05:50:50]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-18 05:51:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-18 05:51:58]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[hashimoto, 2014-08-18 05:55:34]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-08-18 05:56:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/450243002/40001

[laforge, 2014-08-18 06:22:52]

On 2014/08/18 05:56:12, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-status.appspot.com/cq/hashimoto@chromium.org/450243002/40001

LGTM, will have Alex update the tc component.

[commit-bot: I haz the power, 2014-08-18 07:15:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-18 09:52:36]

Committed patchset #2 (40001) as 290230