Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 243433002: Move resources to components/ (Closed)

Created:
6 years, 8 months ago by sdefresne
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@364870.base
Visibility:
Public.

Description

Move resources to components/ Move the resources used by the bookmarks component to components/: IDS_BOOKMARK_BAR_FOLDER_NAME IDS_BOOKMARK_BAR_OTHER_FOLDER_NAME IDS_BOOKMARK_BAR_MOBILE_FOLDER_NAME BUG=364870 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265242

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -37 lines) Patch
M chrome/app/bookmarks_strings.grdp View 2 chunks +0 lines, -33 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_codec.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/external_process_importer_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/utility/importer/safari_importer.mm View 1 chunk +1 line, -0 lines 0 comments Download
A components/bookmarks_strings.grdp View 1 chunk +40 lines, -0 lines 0 comments Download
M components/components_strings.grd View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
sdefresne
6 years, 8 months ago (2014-04-18 17:48:47 UTC) #1
sky
LGTM
6 years, 8 months ago (2014-04-18 20:37:30 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-22 06:58:43 UTC) #3
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 8 months ago (2014-04-22 07:23:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/243433002/20001
6 years, 8 months ago (2014-04-22 07:23:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 08:19:52 UTC) #6
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=173650
6 years, 8 months ago (2014-04-22 08:19:53 UTC) #7
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 8 months ago (2014-04-22 11:29:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/243433002/40001
6 years, 8 months ago (2014-04-22 11:29:37 UTC) #9
sdefresne
The CQ bit was unchecked by sdefresne@chromium.org
6 years, 8 months ago (2014-04-22 12:15:33 UTC) #10
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 8 months ago (2014-04-22 12:15:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/243433002/40001
6 years, 8 months ago (2014-04-22 12:15:50 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 13:24:40 UTC) #13
Message was sent while issue was closed. 
Change committed as 265242

Powered by Google App Engine
This is Rietveld 408576698