Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 85753005: Move policy strings to components/policy_strings.grdp. (Closed)

Created:
7 years ago by dconnelly
Modified:
7 years ago
Reviewers:
Joao da Silva, Jói
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, marja+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move policy strings to components/policy_strings.grdp. This facilitates the refactoring of chrome/browser/policy into a layered component. BUG=271392 TBR=joi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237336

Patch Set 1 #

Patch Set 2 : owners #

Patch Set 3 : update browser_tests dependencies #

Patch Set 4 : update chromeos dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -312 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -287 lines 0 comments Download
M chrome/browser/android/bookmarks/managed_bookmarks_shim.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/login_screen_power_management_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/policy_handlers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/proxy_policy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/message_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_handler_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/javascript_policy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_error_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/url_blacklist_policy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/incognito_mode_policy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/default_search_policy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/restore_on_startup_policy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/policy_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/OWNERS View 1 1 chunk +7 lines, -7 lines 0 comments Download
M components/component_strings.grd View 1 chunk +1 line, -0 lines 0 comments Download
M components/policy.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A components/policy_strings.grdp View 1 chunk +290 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dconnelly
7 years ago (2013-11-25 17:58:25 UTC) #1
Joao da Silva
lgtm!
7 years ago (2013-11-26 08:41:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/85753005/50027
7 years ago (2013-11-26 11:15:30 UTC) #3
Jói
LGTM
7 years ago (2013-11-26 11:17:03 UTC) #4
commit-bot: I haz the power
7 years ago (2013-11-26 14:57:37 UTC) #5
Message was sent while issue was closed. 
Change committed as 237336

Powered by Google App Engine
This is Rietveld 408576698