Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 289993003: Move Translate infobars strings to component_strings (Closed)

Created:
6 years, 7 months ago by droger
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Move Translate infobars strings to component_strings BUG=371845 TBR=jochen Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -87 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -80 lines 0 comments Download
M chrome/browser/translate/options_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/before_translate_infobar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/after_translate_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/before_translate_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/components_strings.grd View 1 chunk +2 lines, -1 line 0 comments Download
A components/translate_strings.grdp View 1 chunk +84 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
droger
6 years, 7 months ago (2014-05-15 14:08:11 UTC) #1
blundell
lgtm
6 years, 7 months ago (2014-05-15 15:31:51 UTC) #2
droger
TBR=jochen
6 years, 7 months ago (2014-05-16 07:38:55 UTC) #3
droger
The CQ bit was checked by droger@chromium.org
6 years, 7 months ago (2014-05-16 07:39:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/289993003/1
6 years, 7 months ago (2014-05-16 07:39:45 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 09:35:57 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 10:42:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/154457)
6 years, 7 months ago (2014-05-16 10:42:15 UTC) #8
droger
The CQ bit was checked by droger@chromium.org
6 years, 7 months ago (2014-05-16 11:04:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/289993003/1
6 years, 7 months ago (2014-05-16 11:04:34 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 11:22:41 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 12:07:58 UTC) #12
Message was sent while issue was closed.
Change committed as 270999

Powered by Google App Engine
This is Rietveld 408576698