Componentize GoogleURLTracker(InfoBarDelegate,MapEntry,NavHelper)

Componentize GoogleURLTracker(InfoBarDelegate,MapEntry,NavHelper)

This CL moves GoogleURLTracker and associated friends to the Google component.
It additionally moves strings that GoogleURLTrackerInfoBarDelegate into
components_strings.grd (via google_strings.grdp).

Dependencies of this code on google_util are temporarily punched through the
embedder, as google_util will require more time to componentize. Once
google_util is componentized, the indirection through the embedder will be
removed.

BUG=373209, 373222
TBR=thakis, cbentzel

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275743

[Peter Kasting, 2014-06-06 18:05:40]

LGTM

https://codereview.chromium.org/316203003/diff/20001/components/google/core/b...
File components/google/core/browser/google_url_tracker.h (right):

https://codereview.chromium.org/316203003/diff/20001/components/google/core/b...
components/google/core/browser/google_url_tracker.h:119: GoogleURLTrackerClient*
client() { return client_.get(); }
Nit: I'd probably put this up by the fetched_google_url() accessor

https://codereview.chromium.org/316203003/diff/20001/components/google/core/b...
File components/google/core/browser/google_url_tracker_client.h (right):

https://codereview.chromium.org/316203003/diff/20001/components/google/core/b...
components/google/core/browser/google_url_tracker_client.h:54: //
TODO(blundell): Eliminate this method in favor of having GoogleURLTracker
Nit: Technically, I think it's the infobar delegate that calls this method. 
Maybe these comments should both just say "callers call".

[blundell, 2014-06-06 18:49:03]

https://codereview.chromium.org/316203003/diff/20001/components/google/core/b...
File components/google/core/browser/google_url_tracker.h (right):

https://codereview.chromium.org/316203003/diff/20001/components/google/core/b...
components/google/core/browser/google_url_tracker.h:119: GoogleURLTrackerClient*
client() { return client_.get(); }
On 2014/06/06 18:05:39, Peter Kasting wrote:
> Nit: I'd probably put this up by the fetched_google_url() accessor

Done.

https://codereview.chromium.org/316203003/diff/20001/components/google/core/b...
File components/google/core/browser/google_url_tracker_client.h (right):

https://codereview.chromium.org/316203003/diff/20001/components/google/core/b...
components/google/core/browser/google_url_tracker_client.h:54: //
TODO(blundell): Eliminate this method in favor of having GoogleURLTracker
On 2014/06/06 18:05:39, Peter Kasting wrote:
> Nit: Technically, I think it's the infobar delegate that calls this method. 
> Maybe these comments should both just say "callers call".

Done.

[blundell, 2014-06-06 18:49:40]

TBR=thakis for //chrome outside of //chrome/browser/google

[blundell, 2014-06-06 18:50:00]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-06 18:53:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/316203003/60001

[blundell, 2014-06-06 19:47:20]

TBR=cbentzel for +net in //components/google/DEPS

[blundell, 2014-06-06 19:47:39]

The CQ bit was unchecked by blundell@chromium.org

[blundell, 2014-06-06 19:53:39]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-06 19:54:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/316203003/80001

[commit-bot: I haz the power, 2014-06-06 23:22:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-06 23:26:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-06 23:26:20]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[blundell, 2014-06-08 09:34:47]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-08 09:35:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/316203003/100001

[commit-bot: I haz the power, 2014-06-08 11:48:12]

Change committed as 275743