Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 442433002: Not allowing user to type more chars than max length value for text field. (Closed)

Created:
6 years, 4 months ago by ankit
Modified:
6 years, 4 months ago
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org, AKVT
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Not allowing user to type more chars than max length value for text field. Added code to handle case When user types chars more than max length value for input text field. Modified imeAdapter#focusedNodeChanged to get max length of input field and using max length value to prevent user to type if text length in input field has exceeded. BUG=400051

Patch Set 1 #

Patch Set 2 : few nits resolved #

Messages

Total messages: 8 (0 generated)
ankit
@aurmias PTAL
6 years, 4 months ago (2014-08-04 09:34:11 UTC) #1
aurimas (slooooooooow)
On 2014/08/04 09:34:11, ankit wrote: > @aurmias > PTAL I think the fix should be ...
6 years, 4 months ago (2014-08-04 15:17:31 UTC) #2
ankit
On 2014/08/04 15:17:31, aurimas wrote: > On 2014/08/04 09:34:11, ankit wrote: > > @aurmias > ...
6 years, 4 months ago (2014-08-04 15:35:21 UTC) #3
aurimas (slooooooooow)
+yosin who works on editing in blink. yosin, can you advice the creator of this ...
6 years, 4 months ago (2014-08-04 15:41:45 UTC) #4
yosin_UTC9
On 2014/08/04 15:41:45, aurimas wrote: > +yosin who works on editing in blink. yosin, can ...
6 years, 4 months ago (2014-08-07 01:31:02 UTC) #5
ankit
On 2014/08/07 01:31:02, Yosi_UTC9 wrote: > On 2014/08/04 15:41:45, aurimas wrote: > > +yosin who ...
6 years, 4 months ago (2014-08-07 04:26:05 UTC) #6
yosin_UTC9
On 2014/08/07 04:26:05, ankit wrote: > On 2014/08/07 01:31:02, Yosi_UTC9 wrote: > > On 2014/08/04 ...
6 years, 4 months ago (2014-08-07 06:20:03 UTC) #7
ankit
6 years, 4 months ago (2014-08-07 06:46:32 UTC) #8
On 2014/08/07 06:20:03, Yosi_UTC9 wrote:
> On 2014/08/07 04:26:05, ankit wrote:
> > On 2014/08/07 01:31:02, Yosi_UTC9 wrote:
> > > On 2014/08/04 15:41:45, aurimas wrote:
> > > > +yosin who works on editing in blink. yosin, can you advice the creator
of
> > > this
> > > > change of where in blink we have the logic to restrict the length of the
> > input
> > > > field? Thanks!
> > > 
> > > Blink doesn't provide logic for restrict number of characters intermediate
> > text
> > > composition.
> > > It seems we should not restrict #chars for intermediate text composition.
> > > For Japanese IME, intermediate composition can have more than "maxlength"
> > > characters but final composition fits to "maxlength" restriction, e.g.
> several
> > > Kana characters to one Kanji character, or some IME can convert ":-)" to
> > Unicode
> > > emotional character. When "maxlength=1" on input field, users can insert
> > Unicode
> > > emotional character for ":-)"
> > 
> > @Yosi
> > So is it intended behavior not to restrict #chars even if it's exceeding max
> > length value?
> > Or we should have some kind of constraint which can handle these scenario. 
> > Please suggest what should be correct approach in this case.
> 
> Yes, this is expected behavior. We don't need to change anything.
> 
> Text field automatically truncates users input by no-IME typing, IME typing,
> Paste with keyboard shortcut, Paste with context menu. When we use script to
set
> value, text field doesn't truncate. But, user can't submit form if text field
> contains characters more than maxlength.

@Yosi
Thanks for clearification.
These changes are not required as the bug reported is not a valid bug.
It is already working as expected.
Closing this issue.

Powered by Google App Engine
This is Rietveld 408576698