content/browser/renderer_host/render_view_host_impl.cc - Issue 442433002: Not allowing user to type more chars than max length value for text field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 442433002: Not allowing user to type more chars than max length value for text field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: few nits resolved Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/browser/renderer_host/render_widget_host_view_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index 0be391ed1f25a8d71bdba882b1e4aeb22a8d35aa..fb127662ca37feff9381b4ee572df52e09d0eda6 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -1268,10 +1268,11 @@ void RenderViewHostImpl::OnTakeFocus(bool reverse) {

view->TakeFocus(reverse);

}

-void RenderViewHostImpl::OnFocusedNodeChanged(bool is_editable_node) {

+void RenderViewHostImpl::OnFocusedNodeChanged(bool is_editable_node,

+ int editable_node_max_length) {

is_focused_element_editable_ = is_editable_node;

if (view_)

- view_->FocusedNodeChanged(is_editable_node);

+ view_->FocusedNodeChanged(is_editable_node, editable_node_max_length);

#if defined(OS_WIN)

if (!is_editable_node && virtual_keyboard_requested_) {

virtual_keyboard_requested_ = false;