content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java - Issue 442433002: Not allowing user to type more chars than max length value for text field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

Issue 442433002: Not allowing user to type more chars than max length value for text field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: few nits resolved Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

index 5f50cd3807c16df73dc4400ebd47d118c67ba3cf..399aa99bc3b909620a6bdd3b095a0e2e81b90a92 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

@@ -127,6 +127,7 @@ public class ImeAdapter {

private DelayedDismissInput mDismissInput = null;

private int mTextInputType;

private String mLastComposeText;

+ private int mInputElementMaxLength;

@VisibleForTesting

int mLastSyntheticKeyCode;

@@ -562,6 +563,9 @@ public class ImeAdapter {

return true;

}

+ public int getInputElementMaxLength() {

+ return mInputElementMaxLength;

+ }

// Calls from C++ to Java

@CalledByNative

@@ -596,7 +600,8 @@ public class ImeAdapter {

}

@CalledByNative

- private void focusedNodeChanged(boolean isEditable) {

+ private void focusedNodeChanged(boolean isEditable, int editableNodeMaxLength) {

+ mInputElementMaxLength = editableNodeMaxLength;

if (mInputConnection != null && isEditable) mInputConnection.restartInput();

}