content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java - Issue 442433002: Not allowing user to type more chars than max length value for text field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

Issue 442433002: Not allowing user to type more chars than max length value for text field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: few nits resolved Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/view_messages.h ('k') | content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

index 36b80513cdbb493fac73603d6a9f1ad3645a2087..3c4015866d1a355c82d2a8cf3f88f022e66205cc 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

@@ -213,6 +213,10 @@ public class AdapterInputConnection extends BaseInputConnection {

@Override

public boolean setComposingText(CharSequence text, int newCursorPosition) {

if (DEBUG) Log.w(TAG, "setComposingText [" + text + "] [" + newCursorPosition + "]");

+ if (mEditable.length() == mImeAdapter.getInputElementMaxLength()) {

+ finishComposingText();

+ return true;

+ }

if (maybePerformEmptyCompositionWorkaround(text)) return true;

super.setComposingText(text, newCursorPosition);

updateSelectionIfRequired();

@@ -225,6 +229,10 @@ public class AdapterInputConnection extends BaseInputConnection {

@Override

public boolean commitText(CharSequence text, int newCursorPosition) {

if (DEBUG) Log.w(TAG, "commitText [" + text + "] [" + newCursorPosition + "]");

+ if (mEditable.length() == mImeAdapter.getInputElementMaxLength()) {

+ finishComposingText();

+ return true;

+ }

if (maybePerformEmptyCompositionWorkaround(text)) return true;

super.commitText(text, newCursorPosition);

updateSelectionIfRequired();