Check that external references are registered in the serializer.

Check that external references are registered in the serializer.

Inspired by a patch by Slava Chigrin <vchigrin@yandex-team.ru>;

R=jkummerow@chromium.org, vchigrin@yandex-team.ru

Committed: https://code.google.com/p/v8/source/detail?r=22896

[Yang, 2014-08-05 12:22:46]

Inspired by CL by Slava Chigrin <vchigrin@yandex-team.ru>
(https://codereview.chromium.org/430213004)

[Jakob Kummerow, 2014-08-05 13:12:07]

LGTM

https://codereview.chromium.org/441983002/diff/40001/src/serialize.cc
File src/serialize.cc (right):

https://codereview.chromium.org/441983002/diff/40001/src/serialize.cc#newcode566
src/serialize.cc:566: for (int i = 0; i < refs_.length() - 1; i++) CHECK(code(i)
!= code(i + 1));
With a little reordering of the TypeCode enum, you could guarantee ascending
(and, hence, unique) codes in linear time without sorting:

int last_seen = -1;
for(int i = 0; i < refs.length(); i++) {
  CHECK(code(i) > last_seen);
  last_seen = code(i);
}

Just for your consideration, I'm fine with either approach.

[Slava Chigrin, 2014-08-05 13:17:04]

https://codereview.chromium.org/441983002/diff/40001/tools/external-reference...
File tools/external-reference-check.py (right):

https://codereview.chromium.org/441983002/diff/40001/tools/external-reference...
tools/external-reference-check.py:17: EXPECTED_EXTERNAL_REFERENCES = 100
Seems, it is not used. Am I wrong?

[Yang, 2014-08-05 13:20:14]

On 2014/08/05 13:17:04, Slava Chigrin wrote:
>
https://codereview.chromium.org/441983002/diff/40001/tools/external-reference...
> File tools/external-reference-check.py (right):
> 
>
https://codereview.chromium.org/441983002/diff/40001/tools/external-reference...
> tools/external-reference-check.py:17: EXPECTED_EXTERNAL_REFERENCES = 100
> Seems, it is not used. Am I wrong?

AHHH. You are right. I planned to use that, but then forgot about it. I'll
remove it, since it doesn't seem to make sense now.

[Yang, 2014-08-05 14:58:31]

On 2014/08/05 13:20:14, Yang wrote:
> On 2014/08/05 13:17:04, Slava Chigrin wrote:
> >
>
https://codereview.chromium.org/441983002/diff/40001/tools/external-reference...
> > File tools/external-reference-check.py (right):
> > 
> >
>
https://codereview.chromium.org/441983002/diff/40001/tools/external-reference...
> > tools/external-reference-check.py:17: EXPECTED_EXTERNAL_REFERENCES = 100
> > Seems, it is not used. Am I wrong?
> 
> AHHH. You are right. I planned to use that, but then forgot about it. I'll
> remove it, since it doesn't seem to make sense now.

Updated.
- removed EXPECTED_EXTERNAL_REFERENCES
- reordered so that the code is added in ascending order
- automatically increment the ID when adding entries to the UNCLASSIFIED type.

[Slava Chigrin, 2014-08-05 15:13:28]

On 2014/08/05 14:58:31, Yang wrote:
> On 2014/08/05 13:20:14, Yang wrote:
> > On 2014/08/05 13:17:04, Slava Chigrin wrote:
> > >
> >
>
https://codereview.chromium.org/441983002/diff/40001/tools/external-reference...
> > > File tools/external-reference-check.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/441983002/diff/40001/tools/external-reference...
> > > tools/external-reference-check.py:17: EXPECTED_EXTERNAL_REFERENCES = 100
> > > Seems, it is not used. Am I wrong?
> > 
> > AHHH. You are right. I planned to use that, but then forgot about it. I'll
> > remove it, since it doesn't seem to make sense now.
> 
> Updated.
> - removed EXPECTED_EXTERNAL_REFERENCES
> - reordered so that the code is added in ascending order
> - automatically increment the ID when adding entries to the UNCLASSIFIED type.

Since I added one comment before, LGTM . 
By the way, I am very thankful for auto-incrementing IDs. :)

[Yang, 2014-08-06 07:20:29]

Committed patchset #5 manually as 22896 (presubmit successful).