Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: tools/presubmit.py

Issue 441983002: Check that external references are registered in the serializer. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/external-reference-check.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/presubmit.py
diff --git a/tools/presubmit.py b/tools/presubmit.py
index c8d3a714070707e032d9434e6fff554660b4d151..cbc21f38945db7ca06336225b3b8958cff961c23 100755
--- a/tools/presubmit.py
+++ b/tools/presubmit.py
@@ -423,6 +423,12 @@ def CheckGeneratedRuntimeTests(workspace):
return code == 0
+def CheckExternalReferenceRegistration(workspace):
+ code = subprocess.call(
+ [sys.executable, join(workspace, "tools", "external-reference-check.py")])
+ return code == 0
+
+
def GetOptions():
result = optparse.OptionParser()
result.add_option('--no-lint', help="Do not run cpplint", default=False,
@@ -442,6 +448,7 @@ def Main():
"two empty lines between declarations check..."
success = SourceProcessor().Run(workspace) and success
success = CheckGeneratedRuntimeTests(workspace) and success
+ success = CheckExternalReferenceRegistration(workspace) and success
if success:
return 0
else:
« no previous file with comments | « tools/external-reference-check.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698