Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: tools/external-reference-check.py

Issue 441983002: Check that external references are registered in the serializer. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-serialize.cc ('k') | tools/presubmit.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 #!/usr/bin/env python
2 # Copyright 2014 the V8 project authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file.
5
6 import re
7 import os
8 import sys
9
10 DECLARE_FILE = "src/assembler.h"
11 REGISTER_FILE = "src/serialize.cc"
12 DECLARE_RE = re.compile("\s*static ExternalReference ([^(]+)\(")
13 REGISTER_RE = re.compile("\s*Add\(ExternalReference::([^(]+)\(")
14
15 WORKSPACE = os.path.abspath(os.path.join(os.path.dirname(sys.argv[0]), ".."))
16
17 # Ignore those.
18 BLACKLISTED = [
19 "page_flags",
20 "math_exp_constants",
21 "math_exp_log_table",
22 "ForDeoptEntry",
23 ]
24
25 def Find(filename, re):
26 references = []
27 with open(filename, "r") as f:
28 for line in f:
29 match = re.match(line)
30 if match:
31 references.append(match.group(1))
32 return references
33
34 def Main():
35 declarations = Find(DECLARE_FILE, DECLARE_RE)
36 registrations = Find(REGISTER_FILE, REGISTER_RE)
37 difference = list(set(declarations) - set(registrations) - set(BLACKLISTED))
38 for reference in difference:
39 print("Declared but not registered: ExternalReference::%s" % reference)
40 return len(difference) > 0
41
42 if __name__ == "__main__":
43 sys.exit(Main())
OLDNEW
« no previous file with comments | « test/cctest/test-serialize.cc ('k') | tools/presubmit.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698