src/ia32/codegen-ia32.cc - Issue 441983002: Check that external references are registered in the serializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/codegen-ia32.cc

Issue 441983002: Check that external references are registered in the serializer. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/codegen-ia32.cc

diff --git a/src/ia32/codegen-ia32.cc b/src/ia32/codegen-ia32.cc

index be74439f9510605ad52715f94082897536319ff2..444f98b16a2bf1155aac091ce08f72e19e7db979 100644

--- a/src/ia32/codegen-ia32.cc

+++ b/src/ia32/codegen-ia32.cc

@@ -929,6 +929,7 @@ void MathExpGenerator::EmitMathExp(MacroAssembler* masm,

DCHECK(!result.is(double_scratch));

DCHECK(!temp1.is(temp2));

DCHECK(ExternalReference::math_exp_constants(0).address() != NULL);

+ DCHECK(!masm->serializer_enabled()); // External references not serializable.

Label done;

« no previous file with comments | « src/assembler.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »