Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: src/ia32/macro-assembler-ia32.cc

Issue 441983002: Check that external references are registered in the serializer. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/mips/codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 3110 matching lines...) Expand 10 before | Expand all | Expand 10 after
3121 3121
3122 3122
3123 void MacroAssembler::CheckPageFlagForMap( 3123 void MacroAssembler::CheckPageFlagForMap(
3124 Handle<Map> map, 3124 Handle<Map> map,
3125 int mask, 3125 int mask,
3126 Condition cc, 3126 Condition cc,
3127 Label* condition_met, 3127 Label* condition_met,
3128 Label::Distance condition_met_distance) { 3128 Label::Distance condition_met_distance) {
3129 DCHECK(cc == zero || cc == not_zero); 3129 DCHECK(cc == zero || cc == not_zero);
3130 Page* page = Page::FromAddress(map->address()); 3130 Page* page = Page::FromAddress(map->address());
3131 DCHECK(!serializer_enabled()); // Serializer cannot match page_flags.
3131 ExternalReference reference(ExternalReference::page_flags(page)); 3132 ExternalReference reference(ExternalReference::page_flags(page));
3132 // The inlined static address check of the page's flags relies 3133 // The inlined static address check of the page's flags relies
3133 // on maps never being compacted. 3134 // on maps never being compacted.
3134 DCHECK(!isolate()->heap()->mark_compact_collector()-> 3135 DCHECK(!isolate()->heap()->mark_compact_collector()->
3135 IsOnEvacuationCandidate(*map)); 3136 IsOnEvacuationCandidate(*map));
3136 if (mask < (1 << kBitsPerByte)) { 3137 if (mask < (1 << kBitsPerByte)) {
3137 test_b(Operand::StaticVariable(reference), static_cast<uint8_t>(mask)); 3138 test_b(Operand::StaticVariable(reference), static_cast<uint8_t>(mask));
3138 } else { 3139 } else {
3139 test(Operand::StaticVariable(reference), Immediate(mask)); 3140 test(Operand::StaticVariable(reference), Immediate(mask));
3140 } 3141 }
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
3430 if (ms.shift() > 0) sar(edx, ms.shift()); 3431 if (ms.shift() > 0) sar(edx, ms.shift());
3431 mov(eax, dividend); 3432 mov(eax, dividend);
3432 shr(eax, 31); 3433 shr(eax, 31);
3433 add(edx, eax); 3434 add(edx, eax);
3434 } 3435 }
3435 3436
3436 3437
3437 } } // namespace v8::internal 3438 } } // namespace v8::internal
3438 3439
3439 #endif // V8_TARGET_ARCH_IA32 3440 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/mips/codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698