Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 436593002: [turbofan] Add Int32AddWithOverflow machine operator. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add Int32AddWithOverflow machine operator. TEST=cctest/test-run-machops,cctest/test-instruction-selector-arm R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22784

Patch Set 1 #

Total comments: 5

Patch Set 2 : Refactor MachineNodeFactory::Int32AddWithOverflow(). #

Patch Set 3 : Add more tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+787 lines, -54 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 3 chunks +16 lines, -2 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 3 chunks +55 lines, -2 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 5 chunks +24 lines, -5 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +38 lines, -0 lines 0 comments Download
M src/compiler/code-generator-impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 3 chunks +16 lines, -2 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +57 lines, -13 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/instruction-codes.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 6 chunks +19 lines, -18 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-node-factory.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/node.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/node.cc View 2 chunks +19 lines, -3 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 3 chunks +16 lines, -2 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 chunks +48 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-instruction-selector-arm.cc View 1 2 1 chunk +357 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 1 chunk +91 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Benedikt Meurer
PTAL
6 years, 4 months ago (2014-07-31 13:32:48 UTC) #1
titzer
https://codereview.chromium.org/436593002/diff/1/src/compiler/arm/instruction-selector-arm.cc File src/compiler/arm/instruction-selector-arm.cc (right): https://codereview.chromium.org/436593002/diff/1/src/compiler/arm/instruction-selector-arm.cc#newcode251 src/compiler/arm/instruction-selector-arm.cc:251: const size_t output_count = ARRAY_SIZE(outputs); Why'd you move that ...
6 years, 4 months ago (2014-07-31 15:16:34 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/436593002/diff/1/src/compiler/arm/instruction-selector-arm.cc File src/compiler/arm/instruction-selector-arm.cc (right): https://codereview.chromium.org/436593002/diff/1/src/compiler/arm/instruction-selector-arm.cc#newcode251 src/compiler/arm/instruction-selector-arm.cc:251: const size_t output_count = ARRAY_SIZE(outputs); For consistency; I plan ...
6 years, 4 months ago (2014-07-31 15:18:20 UTC) #3
titzer
On 2014/07/31 15:18:20, Benedikt Meurer wrote: > https://codereview.chromium.org/436593002/diff/1/src/compiler/arm/instruction-selector-arm.cc > File src/compiler/arm/instruction-selector-arm.cc (right): > > https://codereview.chromium.org/436593002/diff/1/src/compiler/arm/instruction-selector-arm.cc#newcode251 ...
6 years, 4 months ago (2014-07-31 15:20:13 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/436593002/diff/1/src/compiler/machine-node-factory.h File src/compiler/machine-node-factory.h (right): https://codereview.chromium.org/436593002/diff/1/src/compiler/machine-node-factory.h#newcode203 src/compiler/machine-node-factory.h:203: Node* Int32AddWithOverflow(Node* a, Node* b) { On 2014/07/31 15:18:19, ...
6 years, 4 months ago (2014-08-01 05:01:18 UTC) #5
titzer
lgtm
6 years, 4 months ago (2014-08-01 06:55:28 UTC) #6
Benedikt Meurer
6 years, 4 months ago (2014-08-01 09:33:19 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 manually as r22784 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698