[turbofan] Add Int32AddWithOverflow machine operator.

src/compiler/machine-node-factory.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_MACHINE_NODE_FACTORY_H_
 #define V8_COMPILER_MACHINE_NODE_FACTORY_H_
 
 #ifdef USE_SIMULATOR
 #define MACHINE_ASSEMBLER_SUPPORTS_CALL_C 0
 #else
@@ skipping 67 matching lines @@
   }
   Node* Float64Constant(double value) {
     return NEW_NODE_0(COMMON()->Float64Constant(value));
   }
   Node* HeapConstant(Handle<Object> object) {
     PrintableUnique<Object> val =
         PrintableUnique<Object>::CreateUninitialized(ZONE(), object);
     return NEW_NODE_0(COMMON()->HeapConstant(val));
   }
 
+  // Projections.
+  Node* Projection(int index, Node* tuple) {
+    return NEW_NODE_1(COMMON()->Projection(index), tuple);
+  }
+
   // Memory Operations.
   Node* Load(MachineRepresentation rep, Node* base) {
     return Load(rep, base, Int32Constant(0));
   }
   Node* Load(MachineRepresentation rep, Node* base, Node* index) {
     return NEW_NODE_2(MACHINE()->Load(rep), base, index);
   }
   void Store(MachineRepresentation rep, Node* base, Node* value) {
     Store(rep, base, Int32Constant(0), value);
   }
@@ skipping 90 matching lines @@
   }
   Node* Word64NotEqual(Node* a, Node* b) {
     return Word64BinaryNot(Word64Equal(a, b));
   }
   Node* Word64Not(Node* a) { return Word64Xor(a, Int64Constant(-1)); }
   Node* Word64BinaryNot(Node* a) { return Word64Equal(a, Int64Constant(0)); }
 
   Node* Int32Add(Node* a, Node* b) {
     return NEW_NODE_2(MACHINE()->Int32Add(), a, b);
   }
+  Node* Int32AddWithOverflow(Node* a, Node* b) {

[titzer, 2014/07/31 15:16:34]

Maybe we want to return the two projection nodes from this (i.e. accept
{Node**add} {Node** ovf})? Otherwise it's easy to screw it up and use the add
directly, which is a violation.

[Benedikt Meurer, 2014/07/31 15:18:19]

I'd leave it this way for consistency with calls.

[Benedikt Meurer, 2014/08/01 05:01:18]

Done.

+    return NEW_NODE_2(MACHINE()->Int32AddWithOverflow(), a, b);
+  }
   Node* Int32Sub(Node* a, Node* b) {
     return NEW_NODE_2(MACHINE()->Int32Sub(), a, b);
   }
   Node* Int32Mul(Node* a, Node* b) {
     return NEW_NODE_2(MACHINE()->Int32Mul(), a, b);
   }
   Node* Int32Div(Node* a, Node* b) {
     return NEW_NODE_2(MACHINE()->Int32Div(), a, b);
   }
   Node* Int32UDiv(Node* a, Node* b) {
@@ skipping 157 matching lines @@
 #undef NEW_NODE_3
 #undef MACHINE
 #undef COMMON
 #undef ZONE
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_MACHINE_NODE_FACTORY_H_