Always use both a color and coverage attribute in GrAARectRenderer.

Always use both a color and coverage attribute in GrAARectRenderer.

Committed: https://skia.googlesource.com/skia/+/9c0822a4150e23cec9f9b72bd1abc2c5f9ea5a3b

[bsalomon, 2014-07-31 20:47:21]

This solves the batching problem for rotated_rects_aa_change_color.

[robertphillips, 2014-08-04 15:33:10]

So this CL is paused, right?

[bsalomon, 2014-08-04 15:42:44]

On 2014/08/04 15:33:10, robertphillips wrote:
> So this CL is paused, right?

yes

[bsalomon, 2014-08-11 15:08:20]

Unpaused. On my windows machine the significant perf changes are:

rotated_rects_aa_alternating_transparent_and_opaque_src goes from 5.65us to
1.14us on the GPU config. Stays at 12us on angle (unbatchable b/c no DSB)

rotated_rects_aa_changing_transparent_src  and
rotated_rects_aa_changing_opaque_src go from 2 to 1.1us on GPU config

rotated_rects_aa_changing_opaque_src goes from 10.4us to 1.2us on ANGLE (becomes
batchable).

https://codereview.chromium.org/435743002/diff/160001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (left):

https://codereview.chromium.org/435743002/diff/160001/src/gpu/GrContext.cpp#o...
src/gpu/GrContext.cpp:722: static bool isIRect(const SkRect& r) {
This isn't worth it. The perf difference between AA and BW is negligible for
almost all cases.

https://codereview.chromium.org/435743002/diff/160001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/435743002/diff/160001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:1110: if
(!target->getDrawState().canTweakAlphaForCoverage() &&
target->shouldDisableCoverageAAForBlend()) {
will wrap in updated CL.

[bsalomon, 2014-08-11 15:17:58]

The only significant change on the N10 is rotated_rects_aa_changing_opaque_src
goes from 33us to 10.8us.

[bsalomon, 2014-08-11 15:20:26]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-08-11 15:20:40]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/435743002/200001

[commit-bot: I haz the power, 2014-08-11 15:20:41]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-08-11 21:20 UTC

[commit-bot: I haz the power, 2014-08-11 15:24:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Build-Mac10.8-Clang-x86_64-Release-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Mac10.8-Clang-x86_64-Release-Trybo...)
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Try...)
  Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Andr...)
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-...)
  Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Win-VS2013-x86-Debug-Trybot/builds...)
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug...)
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Relea...)

[commit-bot: I haz the power, 2014-08-11 15:25:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-11 15:25:51]

Try jobs failed on following builders:
  Build-Mac10.8-Clang-x86_64-Release-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Mac10.8-Clang-x86_64-Release-Trybo...)
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug...)

[robertphillips, 2014-08-11 15:50:57]

lgtm + suggestions

https://codereview.chromium.org/435743002/diff/200001/src/gpu/GrAARectRendere...
File src/gpu/GrAARectRenderer.cpp (right):

https://codereview.chromium.org/435743002/diff/200001/src/gpu/GrAARectRendere...
src/gpu/GrAARectRenderer.cpp:447:
drawState->setVertexAttribs<gAARectAttribs>(SK_ARRAY_COUNT(gAARectAttribs));
Add a "bool is_opaque(GrColor)" helper to GrColor.h ?

https://codereview.chromium.org/435743002/diff/200001/src/gpu/GrAARectRendere...
src/gpu/GrAARectRenderer.cpp:528: }
Fuse this into prior loop ?

https://codereview.chromium.org/435743002/diff/200001/src/gpu/GrAARectRendere...
src/gpu/GrAARectRenderer.cpp:546: innerCoverage = GrColorPackRGBA(scale, scale,
scale, scale);
Fuse this into prior loop ?

https://codereview.chromium.org/435743002/diff/200001/src/gpu/GrAARectRendere...
src/gpu/GrAARectRenderer.cpp:866: // The outermost rect has 0 coverage
Fuse with prior loop ?

https://codereview.chromium.org/435743002/diff/200001/src/gpu/GrAARectRendere...
src/gpu/GrAARectRenderer.cpp:884: 
Fuse with prior loop ?

https://codereview.chromium.org/435743002/diff/200001/src/gpu/GrAARectRendere...
src/gpu/GrAARectRenderer.cpp:894: }
Fuse with prior loop ?

[bsalomon, 2014-08-11 17:36:18]

All suggestions done.

[bsalomon, 2014-08-11 17:36:21]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-08-11 17:37:25]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/435743002/220001

[commit-bot: I haz the power, 2014-08-11 17:37:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-11 17:37:29]

Failed to apply patch for expectations/gm/ignored-tests.txt:
While running git apply --index -p1;
  error: patch failed: expectations/gm/ignored-tests.txt:37
  error: expectations/gm/ignored-tests.txt: patch does not apply

Patch:       expectations/gm/ignored-tests.txt
Index: expectations/gm/ignored-tests.txt
diff --git a/expectations/gm/ignored-tests.txt
b/expectations/gm/ignored-tests.txt
index
90514b22a0503f5682d81eb7b2867e18830fd244..df47e488ff1429bb01db8cdf435847e867b09b2e
100644
--- a/expectations/gm/ignored-tests.txt
+++ b/expectations/gm/ignored-tests.txt
@@ -37,3 +37,23 @@
 #batching
 bleed
 
+#bungeman: there's now a fontmgr on android
+fontmgr_match
+fontmgr_iter
+
+#bsalomon: https://codereview.chromium.org/435743002
+thinstrokedrects
+thinrects
+drawlooper
+aarectmodes
+mixed_xfermodes
+convex_poly_effect
+rects
+twopointconical
+gradients_2pt_conical_inside
+gradients_local_perspective
+gradient_dirty_laundry
+gradients
+gradients_2pt_conical_edge
+gradients_2pt_conical_outside
+gradients_no_texture
\ No newline at end of file

[bsalomon, 2014-08-11 17:44:28]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-08-11 17:45:24]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/435743002/240001

[commit-bot: I haz the power, 2014-08-11 17:52:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Try...)
  Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Andr...)
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-...)

[commit-bot: I haz the power, 2014-08-11 17:55:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-11 17:55:59]

Try jobs failed on following builders:
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Try...)

[bsalomon, 2014-08-11 17:59:27]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-08-11 18:00:28]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/435743002/260001

[commit-bot: I haz the power, 2014-08-11 18:07:53]

Change committed as 9c0822a4150e23cec9f9b72bd1abc2c5f9ea5a3b