Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 431453004: wtf/Vector.h included more than necessary (Closed)

Created:
6 years, 4 months ago by Gaja
Modified:
6 years, 4 months ago
CC:
aandrey+blink_chromium.org, abarth-chromium, darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, blink-reviews-wtf_chromium.org, Rik, caseq+blink_chromium.org, danakj, devtools-reviews_chromium.org, dglazkov+blink, krit, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, eric.carlson_apple.com, Eric Willigers, eustas+blink_chromium.org, feature-media-reviews_chromium.org, f(malita), fs, gavinp+loader_chromium.org, gyuyoung.kim_webkit.org, jamesr, Nate Chapin, jbroman, jchaffraix+rendering, jfernandez, kouhei+svg_chromium.org, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, Mike Lawther (Google), Mikhail, paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, philipj_slow, Manuel Rego, rjwright, rwlbuis, Raymond Toy, rune+blink, Stephen Chennney, sergeyv+blink_chromium.org, shans, sof, Steve Block, svillar, Timothy Loh, tommyw+watchlist_chromium.org, vsevik+blink_chromium.org, webcomponents-bugzilla_chromium.org, yurys+blink_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

wtf/Vector.h included more than necessary There are files that include Vector.h without needing it. That triggers builds bigger than needed when working on the Vector class. BUG=398455 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
M Source/bindings/core/v8/ScriptPromiseResolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/clipboard/Pasteboard.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Microtask.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/CSSStyleSheetResource.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/ImageResource.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/XSLStyleSheetResource.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportChild.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorController.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorFrontendClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/ScriptAsyncCallStack.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/OrderIterator.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/GraphicsLayerTreeBuilder.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/shapes/RectangleShape.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/shapes/ShapeOutsideInfo.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/style/StyleGridItemData.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequestUpload.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XPathUtil.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XSLTProcessor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XSLTProcessorLibxslt.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/gamepad/GamepadList.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/gamepad/WebKitGamepadList.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioNodeInput.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioNodeOutput.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/SQLStatement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/websockets/WebSocketPerMessageDeflateTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/CalculationValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/MIMETypeRegistry.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/PODArenaTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/PODFreeListArenaTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/PlatformTouchPoint.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/animation/TimingFunction.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/exported/WebMediaStreamTrack.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/exported/WebSpeechSynthesisVoice.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/FontPlatformData.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/BitmapImage.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/ImageSource.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/filters/FEMerge.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/filters/FEMorphology.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/network/ContentSecurityPolicyParsers.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/text/StringTruncator.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/CompositionUnderlineBuilder.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/InspectorClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebUserMediaRequest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/wtf/ArrayBuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/wtf/text/TextCodec.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
Gaja
6 years, 4 months ago (2014-07-30 13:12:04 UTC) #1
Gaja
6 years, 4 months ago (2014-07-30 13:13:54 UTC) #2
jochen (gone - plz use gerrit)
please don't use NOTRY=true
6 years, 4 months ago (2014-07-30 13:46:25 UTC) #3
Gaja
On 2014/07/30 13:46:25, jochen wrote: > please don't use NOTRY=true Removed it. Please review.
6 years, 4 months ago (2014-07-30 16:32:03 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-08-01 11:08:17 UTC) #5
Gaja
The CQ bit was checked by gajendra.n@samsung.com
6 years, 4 months ago (2014-08-01 11:08:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gajendra.n@samsung.com/431453004/1
6 years, 4 months ago (2014-08-01 11:09:13 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-01 12:24:19 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-01 13:04:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20126)
6 years, 4 months ago (2014-08-01 13:04:09 UTC) #10
Gaja
The CQ bit was checked by gajendra.n@samsung.com
6 years, 4 months ago (2014-08-01 13:35:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gajendra.n@samsung.com/431453004/1
6 years, 4 months ago (2014-08-01 13:36:28 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-01 14:16:31 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-01 15:03:57 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20151)
6 years, 4 months ago (2014-08-01 15:03:59 UTC) #15
Gaja
The CQ bit was checked by gajendra.n@samsung.com
6 years, 4 months ago (2014-08-01 17:38:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gajendra.n@samsung.com/431453004/1
6 years, 4 months ago (2014-08-01 17:38:48 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 18:14:05 UTC) #18
Message was sent while issue was closed.
Change committed as 179410

Powered by Google App Engine
This is Rietveld 408576698