Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 429793006: Update several clang warnings after r287092. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
4 years, 9 months ago
Reviewers:
hans
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update several clang warnings after r287092. I missed a few targets that I though were deps'd in, but which (thankfully) just live in the regular tree. BUG=none R=hans@chromium.org TBR=cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -53 lines) Patch
M third_party/harfbuzz-ng/harfbuzz.gyp View 1 chunk +3 lines, -10 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 2 chunks +6 lines, -11 lines 0 comments Download
M third_party/mesa/mesa_gensrc.gypi View 2 chunks +9 lines, -19 lines 0 comments Download
M third_party/yasm/yasm.gyp View 2 chunks +6 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
6 years, 4 months ago (2014-08-01 22:43:16 UTC) #1
hans
lgtm
6 years, 4 months ago (2014-08-01 23:33:54 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-01 23:46:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/429793006/1
6 years, 4 months ago (2014-08-01 23:48:46 UTC) #4
Nico
6 years, 4 months ago (2014-08-02 00:46:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as 287137 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698