Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/mesa/mesa_gensrc.gypi

Issue 429793006: Update several clang warnings after r287092. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/libjingle/libjingle.gyp ('k') | third_party/yasm/yasm.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/mesa/mesa_gensrc.gypi
diff --git a/third_party/mesa/mesa_gensrc.gypi b/third_party/mesa/mesa_gensrc.gypi
index b5e6529771e9c212c63449dfc1a96fd69e1c38a1..8b4b225a4c7ce4194dd3289d3e1c0d2090cf559d 100644
--- a/third_party/mesa/mesa_gensrc.gypi
+++ b/third_party/mesa/mesa_gensrc.gypi
@@ -101,6 +101,15 @@
'mesa_headers',
'mesa_libglslcommon', # implicit dependency on generate_main_mesa_sources
],
+ 'variables': {
+ 'clang_warning_flags': [
+ '-Wno-tautological-constant-out-of-range-compare',
+ ],
+ 'clang_warning_flags_unset': [
+ # Don't warn about string->bool used in asserts.
+ '-Wstring-conversion',
+ ],
+ },
'sources': [
'src/src/mesa/program/hash_table.c',
'src/src/mesa/program/symbol_table.c',
@@ -108,25 +117,6 @@
'src/src/glsl/main.cpp',
'src/src/glsl/builtin_stubs.cpp',
],
- 'conditions': [
- ['clang == 1', {
- 'xcode_settings': {
- 'WARNING_CFLAGS': [
- '-Wno-tautological-constant-out-of-range-compare',
- ],
- 'WARNING_CFLAGS!': [
- # Don't warn about string->bool used in asserts.
- '-Wstring-conversion',
- ],
- },
- 'cflags': [
- '-Wtautological-constant-out-of-range-compare',
- ],
- 'cflags!': [
- '-Wstring-conversion',
- ],
- }],
- ],
},
{
'target_name': 'generate_mesa_sources',
« no previous file with comments | « third_party/libjingle/libjingle.gyp ('k') | third_party/yasm/yasm.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698