Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/harfbuzz-ng/harfbuzz.gyp

Issue 429793006: Update several clang warnings after r287092. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/libjingle/libjingle.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/harfbuzz-ng/harfbuzz.gyp
diff --git a/third_party/harfbuzz-ng/harfbuzz.gyp b/third_party/harfbuzz-ng/harfbuzz.gyp
index 77b0fee99c3f08988647020903efe562b274f924..6cfed6559229eb5122de38cb19b1d94a7c60f4b6 100644
--- a/third_party/harfbuzz-ng/harfbuzz.gyp
+++ b/third_party/harfbuzz-ng/harfbuzz.gyp
@@ -145,17 +145,10 @@
'dependencies': [
'../../third_party/icu/icu.gyp:icuuc',
],
+ 'variables': {
+ 'clang_warning_flags': [ '-Wno-unused-value', ],
+ },
'conditions': [
- ['clang==1', {
- 'xcode_settings': {
- 'WARNING_CFLAGS': [
- '-Wno-unused-value',
- ],
- },
- 'cflags': [
- '-Wno-unused-value',
- ]
- }],
['OS=="win"', {
# TODO(eae): C4267 on amd64. size_t -> int, size_t -> unsigned int
'msvs_disabled_warnings': [4267, 4334],
« no previous file with comments | « no previous file | third_party/libjingle/libjingle.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698