Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: third_party/libjingle/libjingle.gyp

Issue 429793006: Update several clang warnings after r287092. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/harfbuzz-ng/harfbuzz.gyp ('k') | third_party/mesa/mesa_gensrc.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libjingle/libjingle.gyp
diff --git a/third_party/libjingle/libjingle.gyp b/third_party/libjingle/libjingle.gyp
index 4ec4641429eef1e8f64381e15dfd431576529e9e..1ac789beca38a91b154645f1b70227cd44d75f87 100644
--- a/third_party/libjingle/libjingle.gyp
+++ b/third_party/libjingle/libjingle.gyp
@@ -148,6 +148,12 @@
}
},
},
+ 'variables': {
+ 'clang_warning_flags_unset': [
+ # Don't warn about string->bool used in asserts.
+ '-Wstring-conversion',
+ ],
+ },
'conditions': [
['"<(libpeer_target_type)"=="static_library"', {
'defines': [ 'LIBPEERCONNECTION_LIB=1' ],
@@ -193,17 +199,6 @@
}],
],
}],
- ['clang == 1', {
- 'xcode_settings': {
- 'WARNING_CFLAGS!': [
- # Don't warn about string->bool used in asserts.
- '-Wstring-conversion',
- ],
- },
- 'cflags!': [
- '-Wstring-conversion',
- ],
- }],
['OS=="linux"', {
'defines': [
'LINUX',
« no previous file with comments | « third_party/harfbuzz-ng/harfbuzz.gyp ('k') | third_party/mesa/mesa_gensrc.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698