Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 422903002: Test abandoning GL context in dm/nanobench. (Closed)

Created:
6 years, 4 months ago by bsalomon
Modified:
6 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org, mtklein
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Test abandoning GL context in dm/nanobench. Rename GrContext::contextDestroyed to GrContext::abandonContext. Remove GrContext::resetContext. Committed: https://skia.googlesource.com/skia/+/2354f8432a7205571f04f9638a0018fb0b1fb282

Patch Set 1 #

Patch Set 2 : incorrect fix #

Patch Set 3 : modify comment, remove incorrect bug fix #

Patch Set 4 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -27 lines) Patch
M bench/nanobench.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M dm/DMGpuSupport.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M dm/DMTask.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M include/gpu/GrContext.h View 1 2 1 chunk +13 lines, -16 lines 0 comments Download
M include/gpu/GrContextFactory.h View 1 chunk +13 lines, -2 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M tools/flags/SkCommonFlags.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
bsalomon
6 years, 4 months ago (2014-07-28 15:23:05 UTC) #1
robertphillips
lgtm
6 years, 4 months ago (2014-07-28 15:29:18 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-07-28 15:42:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/422903002/40001
6 years, 4 months ago (2014-07-28 15:42:14 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-07-28 15:46:55 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 15:49:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot/builds/885)
6 years, 4 months ago (2014-07-28 15:49:26 UTC) #7
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-07-28 19:33:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/422903002/60001
6 years, 4 months ago (2014-07-28 19:34:27 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-07-28 19:45:47 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 19:50:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1001)
6 years, 4 months ago (2014-07-28 19:50:17 UTC) #12
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-07-28 20:32:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/422903002/60001
6 years, 4 months ago (2014-07-28 20:32:42 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 20:48:41 UTC) #15
Message was sent while issue was closed. 
Change committed as 2354f8432a7205571f04f9638a0018fb0b1fb282

Powered by Google App Engine
This is Rietveld 408576698