Issue 416543006: Revert 284958 "Make HistoryDBTask not refcounted, and ensure it'..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 416543006: Revert 284958 "Make HistoryDBTask not refcounted, and ensure it'..." (Closed)

Created:
6 years, 5 months ago by stgao

Modified:
6 years, 5 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 284958 "Make HistoryDBTask not refcounted, and ensure it'..." It breaks http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/5252 > Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread. > > BUG=393149 > > Review URL: https://codereview.chromium.org/387923002 TBR=bauerb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285002

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+108 lines, -174 lines)			Patch
M	trunk/src/chrome/browser/history/delete_directive_handler.cc	View	2 chunks	+6 lines, -8 lines	0 comments	Download
M	trunk/src/chrome/browser/history/history_backend.h	View	3 chunks	+6 lines, -10 lines	0 comments	Download
M	trunk/src/chrome/browser/history/history_backend.cc	View	4 chunks	+17 lines, -26 lines	0 comments	Download
M	trunk/src/chrome/browser/history/history_browsertest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/history/history_db_task.h	View	3 chunks	+9 lines, -5 lines	0 comments	Download
M	trunk/src/chrome/browser/history/history_service.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/history/history_service.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/history/history_unittest.cc	View	3 chunks	+12 lines, -21 lines	0 comments	Download
M	trunk/src/chrome/browser/history/in_memory_url_index.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/history/top_sites_impl_unittest.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/history/url_index_private_data.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/prerender/prerender_local_predictor.cc	View	2 chunks	+6 lines, -10 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/glue/history_model_worker.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc	View	3 chunks	+20 lines, -34 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/test/integration/bookmarks_helper.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/test/integration/typed_urls_helper.cc	View	5 chunks	+7 lines, -20 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/search/instant_extended_interactive_uitest.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/test/base/testing_profile.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r285002.

Expand Messages | Collapse Messages