Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: trunk/src/chrome/browser/sync/test/integration/typed_urls_helper.cc

Issue 416543006: Revert 284958 "Make HistoryDBTask not refcounted, and ensure it'..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/sync/test/integration/typed_urls_helper.cc
===================================================================
--- trunk/src/chrome/browser/sync/test/integration/typed_urls_helper.cc (revision 285001)
+++ trunk/src/chrome/browser/sync/test/integration/typed_urls_helper.cc (working copy)
@@ -145,10 +145,7 @@
HistoryService* service = HistoryServiceFactory::GetForProfileWithoutCreating(
test()->GetProfile(index));
base::WaitableEvent wait_event(true, false);
- service->ScheduleDBTask(
- scoped_ptr<history::HistoryDBTask>(
- new FlushHistoryDBQueueTask(&wait_event)),
- &tracker);
+ service->ScheduleDBTask(new FlushHistoryDBQueueTask(&wait_event), &tracker);
wait_event.Wait();
}
@@ -175,10 +172,7 @@
base::CancelableTaskTracker tracker;
history::URLRows rows;
base::WaitableEvent wait_event(true, false);
- service->ScheduleDBTask(
- scoped_ptr<history::HistoryDBTask>(
- new GetTypedUrlsTask(&rows, &wait_event)),
- &tracker);
+ service->ScheduleDBTask(new GetTypedUrlsTask(&rows, &wait_event), &tracker);
wait_event.Wait();
return rows;
}
@@ -188,10 +182,8 @@
base::CancelableTaskTracker tracker;
base::WaitableEvent wait_event(true, false);
bool found = false;
- service->ScheduleDBTask(
- scoped_ptr<history::HistoryDBTask>(
- new GetUrlTask(url, row, &found, &wait_event)),
- &tracker);
+ service->ScheduleDBTask(new GetUrlTask(url, row, &found, &wait_event),
+ &tracker);
wait_event.Wait();
return found;
}
@@ -201,10 +193,8 @@
base::CancelableTaskTracker tracker;
base::WaitableEvent wait_event(true, false);
history::VisitVector visits;
- service->ScheduleDBTask(
- scoped_ptr<history::HistoryDBTask>(
- new GetVisitsTask(id, &visits, &wait_event)),
- &tracker);
+ service->ScheduleDBTask(new GetVisitsTask(id, &visits, &wait_event),
+ &tracker);
wait_event.Wait();
return visits;
}
@@ -213,10 +203,7 @@
const history::VisitVector& visits) {
base::CancelableTaskTracker tracker;
base::WaitableEvent wait_event(true, false);
- service->ScheduleDBTask(
- scoped_ptr<history::HistoryDBTask>(
- new RemoveVisitsTask(visits, &wait_event)),
- &tracker);
+ service->ScheduleDBTask(new RemoveVisitsTask(visits, &wait_event), &tracker);
wait_event.Wait();
}

Powered by Google App Engine
This is Rietveld 408576698