Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: trunk/src/chrome/browser/prerender/prerender_local_predictor.cc

Issue 416543006: Revert 284958 "Make HistoryDBTask not refcounted, and ensure it'..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/prerender/prerender_local_predictor.cc
===================================================================
--- trunk/src/chrome/browser/prerender/prerender_local_predictor.cc (revision 285001)
+++ trunk/src/chrome/browser/prerender/prerender_local_predictor.cc (working copy)
@@ -555,12 +555,10 @@
RecordEvent(EVENT_GOT_HISTORY_ISSUING_LOOKUP);
CandidatePrerenderInfo* lookup_info_ptr = lookup_info.get();
history->ScheduleDBTask(
- scoped_ptr<history::HistoryDBTask>(
- new GetURLForURLIDTask(
- lookup_info_ptr,
- base::Bind(&PrerenderLocalPredictor::OnLookupURL,
- base::Unretained(this),
- base::Passed(&lookup_info)))),
+ new GetURLForURLIDTask(lookup_info_ptr,
+ base::Bind(&PrerenderLocalPredictor::OnLookupURL,
+ base::Unretained(this),
+ base::Passed(&lookup_info))),
&history_db_tracker_);
}
}
@@ -1000,10 +998,8 @@
HistoryService* history = GetHistoryIfExists();
if (history) {
CHECK(!is_visit_database_observer_);
- history->ScheduleDBTask(
- scoped_ptr<history::HistoryDBTask>(
- new GetVisitHistoryTask(this, kMaxVisitHistory)),
- &history_db_tracker_);
+ history->ScheduleDBTask(new GetVisitHistoryTask(this, kMaxVisitHistory),
+ &history_db_tracker_);
history->AddVisitDatabaseObserver(this);
is_visit_database_observer_ = true;
} else {
« no previous file with comments | « trunk/src/chrome/browser/history/url_index_private_data.cc ('k') | trunk/src/chrome/browser/sync/glue/history_model_worker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698