Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: trunk/src/chrome/browser/history/history_browsertest.cc

Issue 416543006: Revert 284958 "Make HistoryDBTask not refcounted, and ensure it'..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/prefs/pref_service.h" 10 #include "base/prefs/pref_service.h"
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 } 80 }
81 81
82 GURL GetTestUrl() { 82 GURL GetTestUrl() {
83 return ui_test_utils::GetTestUrl( 83 return ui_test_utils::GetTestUrl(
84 base::FilePath(base::FilePath::kCurrentDirectory), 84 base::FilePath(base::FilePath::kCurrentDirectory),
85 base::FilePath(FILE_PATH_LITERAL("title2.html"))); 85 base::FilePath(FILE_PATH_LITERAL("title2.html")));
86 } 86 }
87 87
88 void WaitForHistoryBackendToRun() { 88 void WaitForHistoryBackendToRun() {
89 base::CancelableTaskTracker task_tracker; 89 base::CancelableTaskTracker task_tracker;
90 scoped_ptr<history::HistoryDBTask> task(new WaitForHistoryTask()); 90 scoped_refptr<history::HistoryDBTask> task(new WaitForHistoryTask());
91 HistoryService* history = 91 HistoryService* history =
92 HistoryServiceFactory::GetForProfile(GetProfile(), 92 HistoryServiceFactory::GetForProfile(GetProfile(),
93 Profile::EXPLICIT_ACCESS); 93 Profile::EXPLICIT_ACCESS);
94 history->HistoryService::ScheduleDBTask(task.Pass(), &task_tracker); 94 history->HistoryService::ScheduleDBTask(task.get(), &task_tracker);
95 content::RunMessageLoop(); 95 content::RunMessageLoop();
96 } 96 }
97 97
98 void ExpectEmptyHistory() { 98 void ExpectEmptyHistory() {
99 std::vector<GURL> urls(GetHistoryContents()); 99 std::vector<GURL> urls(GetHistoryContents());
100 EXPECT_EQ(0U, urls.size()); 100 EXPECT_EQ(0U, urls.size());
101 } 101 }
102 102
103 void LoadAndWaitForURL(const GURL& url) { 103 void LoadAndWaitForURL(const GURL& url) {
104 base::string16 expected_title(base::ASCIIToUTF16("OK")); 104 base::string16 expected_title(base::ASCIIToUTF16("OK"));
(...skipping 397 matching lines...) Expand 10 before | Expand all | Expand 10 after
502 502
503 content::WebContents* active_web_contents = 503 content::WebContents* active_web_contents =
504 browser()->tab_strip_model()->GetActiveWebContents(); 504 browser()->tab_strip_model()->GetActiveWebContents();
505 ASSERT_EQ(web_contents, active_web_contents); 505 ASSERT_EQ(web_contents, active_web_contents);
506 ASSERT_EQ(history_url, active_web_contents->GetURL()); 506 ASSERT_EQ(history_url, active_web_contents->GetURL());
507 507
508 content::WebContents* second_tab = 508 content::WebContents* second_tab =
509 browser()->tab_strip_model()->GetWebContentsAt(1); 509 browser()->tab_strip_model()->GetWebContentsAt(1);
510 ASSERT_NE(history_url, second_tab->GetURL()); 510 ASSERT_NE(history_url, second_tab->GetURL());
511 } 511 }
OLDNEW
« no previous file with comments | « trunk/src/chrome/browser/history/history_backend.cc ('k') | trunk/src/chrome/browser/history/history_db_task.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698