Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 416273005: cc/output: cleanup: Remove unnecessary #includes (Closed)

Created:
6 years, 5 months ago by hj.r.chung
Modified:
6 years, 4 months ago
Reviewers:
danakj, piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc/output: cleanup: Remove unnecessary #includes Remove or move/change #includes to appropriate places/ones. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285835

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -77 lines) Patch
M cc/output/begin_frame_args.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/compositor_frame_metadata.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/output/delegated_frame_data.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/output/delegating_renderer.cc View 1 chunk +2 lines, -12 lines 0 comments Download
M cc/output/direct_renderer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/filter_operation.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/filter_operation.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/geometry_binding.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/gl_frame_data.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/output/gl_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/output/output_surface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/output/output_surface.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M cc/output/output_surface_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/overlay_candidate.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/overlay_candidate.cc View 1 chunk +3 lines, -1 line 0 comments Download
M cc/output/overlay_candidate_validator.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/output/overlay_processor.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/output/overlay_strategy_single_on_top.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/program_binding.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/render_surface_filters.cc View 2 chunks +1 line, -6 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/output/shader.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/shader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/shader_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/output/software_frame_data.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/output/software_output_device.h View 1 chunk +3 lines, -5 lines 0 comments Download
M cc/output/software_output_device.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/software_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
hj.r.chung
PTAL! This removes 40+ unnecessary #includes in cc/output.
6 years, 5 months ago (2014-07-25 10:29:25 UTC) #1
piman
lgtm
6 years, 5 months ago (2014-07-26 01:48:44 UTC) #2
hj.r.chung
On 2014/07/26 01:48:44, piman (slow to review) wrote: > lgtm thanks!
6 years, 5 months ago (2014-07-26 11:52:44 UTC) #3
hj.r.chung
The CQ bit was checked by heejin.r.chung@samsung.com
6 years, 5 months ago (2014-07-26 11:52:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heejin.r.chung@samsung.com/416273005/1
6 years, 5 months ago (2014-07-26 11:54:56 UTC) #5
hj.r.chung
The CQ bit was unchecked by heejin.r.chung@samsung.com
6 years, 5 months ago (2014-07-26 16:10:15 UTC) #6
hj.r.chung
The CQ bit was checked by heejin.r.chung@samsung.com
6 years, 4 months ago (2014-07-27 09:54:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heejin.r.chung@samsung.com/416273005/1
6 years, 4 months ago (2014-07-27 09:54:51 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-07-27 11:22:56 UTC) #9
Message was sent while issue was closed. 
Change committed as 285835

Powered by Google App Engine
This is Rietveld 408576698