Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 413073004: Show non-Blink ranges in sheriff-o-matic. (Closed)

Created:
6 years, 5 months ago by ojan
Modified:
6 years, 4 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Show non-Blink ranges in sheriff-o-matic. Show regression ranges for chromium/nacl/v8. Make CTCommitLog contain a map of repository to commits and a map of repository to the first revision the CTCommitLog has. Switch over to querying the data as JSON from googlesource instead of XML from blink.lc. Pass a map of repository -> revision for ct-commit-list's first and last attributes and have ct-commit-list call out to CTCommitLog to get the list of commits instead of generating them itself. If we don't have data for a commit, create an incomplete CTCommit so that we at least show the repository + revision number instead of showing nothing. This is for when the commits in the regression range are older than the default number that googlesource's log shows. We don't create an incomplete commit for revisions we don't have data for that are after the first commit we have data for because those are the commits that are on branches, which we don't want to show. Also, delete unused ct-failure-grouper. I can move this into a separate patch if you'd like. NOTRY=true

Patch Set 1 #

Patch Set 2 : ready for review #

Patch Set 3 : add missing files #

Total comments: 6

Patch Set 4 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -319 lines) Patch
M Tools/GardeningServer/model/ct-commit.html View 1 1 chunk +22 lines, -10 lines 0 comments Download
M Tools/GardeningServer/model/ct-commit-log.html View 1 2 3 1 chunk +43 lines, -18 lines 0 comments Download
M Tools/GardeningServer/model/ct-commit-log-mock.html View 1 1 chunk +3 lines, -1 line 0 comments Download
M Tools/GardeningServer/model/ct-commit-log-tests.html View 1 2 3 1 chunk +45 lines, -20 lines 0 comments Download
M Tools/GardeningServer/model/ct-commit-mock.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M Tools/GardeningServer/model/ct-commit-tests.html View 1 3 chunks +20 lines, -7 lines 0 comments Download
M Tools/GardeningServer/model/ct-failure.html View 1 chunk +3 lines, -3 lines 0 comments Download
A Tools/GardeningServer/model/ct-repositories.html View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A + Tools/GardeningServer/model/ct-repository.html View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M Tools/GardeningServer/run-unittests.html View 1 chunk +0 lines, -1 line 0 comments Download
M Tools/GardeningServer/ui/ct-commit.html View 1 chunk +1 line, -1 line 0 comments Download
M Tools/GardeningServer/ui/ct-commit-list.html View 1 1 chunk +25 lines, -13 lines 0 comments Download
M Tools/GardeningServer/ui/ct-commit-list-tests.html View 1 1 chunk +34 lines, -6 lines 0 comments Download
M Tools/GardeningServer/ui/ct-commit-tests.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Tools/GardeningServer/ui/ct-failure-analyzer.html View 1 2 3 1 chunk +1 line, -10 lines 0 comments Download
M Tools/GardeningServer/ui/ct-failure-card.html View 1 chunk +6 lines, -6 lines 0 comments Download
D Tools/GardeningServer/ui/ct-failure-grouper.html View 1 chunk +0 lines, -36 lines 0 comments Download
D Tools/GardeningServer/ui/ct-failure-grouper-tests.html View 1 chunk +0 lines, -178 lines 0 comments Download
M Tools/GardeningServer/ui/ct-unexpected-failures.html View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ojan
This depends on https://codereview.chromium.org/416673003. After this, we just need to show information for different waterfalls ...
6 years, 5 months ago (2014-07-25 01:38:58 UTC) #1
abarth-chromium
LGTM https://codereview.chromium.org/413073004/diff/40001/Tools/GardeningServer/model/ct-commit-log.html File Tools/GardeningServer/model/ct-commit-log.html (right): https://codereview.chromium.org/413073004/diff/40001/Tools/GardeningServer/model/ct-commit-log.html#newcode20 Tools/GardeningServer/model/ct-commit-log.html:20: Object.keys(this._repositories.repositories, (function(name, repository) { repositories, repositories, repositories, repositories ...
6 years, 4 months ago (2014-07-29 16:22:26 UTC) #2
ojan
https://codereview.chromium.org/413073004/diff/40001/Tools/GardeningServer/model/ct-commit-log.html File Tools/GardeningServer/model/ct-commit-log.html (right): https://codereview.chromium.org/413073004/diff/40001/Tools/GardeningServer/model/ct-commit-log.html#newcode20 Tools/GardeningServer/model/ct-commit-log.html:20: Object.keys(this._repositories.repositories, (function(name, repository) { On 2014/07/29 16:22:26, abarth wrote: ...
6 years, 4 months ago (2014-07-30 04:14:33 UTC) #3
ojan
6 years, 4 months ago (2014-07-30 05:04:11 UTC) #4
Whoops. I accidentally committed this as part of
https://codereview.chromium.org/418253002.

Powered by Google App Engine
This is Rietveld 408576698