Tools/GardeningServer/model/ct-failure.html - Issue 413073004: Show non-Blink ranges in sheriff-o-matic.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Tools/GardeningServer/model/ct-failure.html

Issue 413073004: Show non-Blink ranges in sheriff-o-matic. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: address review comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!--	1 <!--

2 Copyright 2014 The Chromium Authors. All rights reserved.	2 Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5 -->	5 -->

6	6

7 <script>	7 <script>

8 function CTFailure(step, reason, resultsByBuilder, oldestFailingRevision, newest PassingRevision) {	8 function CTFailure(step, reason, resultsByBuilder, firstFailingRevisions, lastPa ssingRevisions) {

9 this.step = step;	9 this.step = step;

10 // FIXME: Rename this to reason.	10 // FIXME: Rename this to reason.

11 this.testName = reason;	11 this.testName = reason;

12 this.resultNodesByBuilder = resultsByBuilder;	12 this.resultNodesByBuilder = resultsByBuilder;

13 // FIXME: Move these up one layer to the groupedFailures object.	13 // FIXME: Move these up one layer to the groupedFailures object.

14 this.oldestFailingRevision = oldestFailingRevision;	14 this.firstFailingRevisions = firstFailingRevisions;

15 this.newestPassingRevision = newestPassingRevision;	15 this.lastPassingRevisions = lastPassingRevisions;

16 }	16 }

17 </script>	17 </script>

OLD	NEW