Show non-webkit test failures in the failure stream

Show non-webkit test failures in the failure stream

-Remove ct-failing-builders and instead show all failures in the stream the
same way we do for webkit tests.
-Sort the failures in a group by step name then by test name.
-Do the dumb object --> model classes transition in small pieces to avoid blocking
getting a minimally viable product ready too much on completely doing this
refactoring.

The UI is not awesome, but I wanted to get the functionality in place first.

NOTRY=true
R=abarth@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179194

[ojan, 2014-07-24 00:05:57]

Fixed subject line.

[ojan, 2014-07-24 05:33:28]

BTW, abarth is on vacation. Anyone else willing to do this review?

[szager1, 2014-07-25 23:53:17]

https://codereview.chromium.org/416673003/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/ct-failure-card.html (right):

https://codereview.chromium.org/416673003/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/ct-failure-card.html:65: <paper-button id="examine"
on-tap="{{examine}}">Examine</paper-button>
Can we hide this button if it doesn't work, e.g., on non-webkit tests?

https://codereview.chromium.org/416673003/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/ct-test-list.html (right):

https://codereview.chromium.org/416673003/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/ct-test-list.html:22: return
ui.urlForFlakinessDashboard(test.testName, test.step);
The 'Examine' button seems to be busted for webkit and non-webkit tests. 
Running this patch locally, clicking the button does nothing.

[ojan, 2014-07-26 17:21:53]

Examine button works fine for me. :(

[abarth-chromium, 2014-07-29 16:38:17]

LGTM

https://codereview.chromium.org/416673003/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/ct-results-detail.html (right):

https://codereview.chromium.org/416673003/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/ct-results-detail.html:99: '/logs/' + testPart;
Should this work be done by some model object?  Having this logic in the view
seems odd.

https://codereview.chromium.org/416673003/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/ct-results-panel.html (right):

https://codereview.chromium.org/416673003/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/ct-results-panel.html:58: <template if="{{
failures[selected].testName != 'whole step failed' }}">
It's sad that 'whole step failed' is used as a magic value.  Can we make the
testName null instead?

[abarth-chromium, 2014-07-29 16:38:18]

LGTM

[ojan, 2014-07-30 03:56:39]

Committed patchset #3 manually as r179194 (tree was closed).

[ojan, 2014-07-30 04:14:17]

https://codereview.chromium.org/416673003/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/ct-results-detail.html (right):

https://codereview.chromium.org/416673003/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/ct-results-detail.html:99: '/logs/' + testPart;
On 2014/07/29 16:38:17, abarth wrote:
> Should this work be done by some model object?  Having this logic in the view
> seems odd.

Absolutely, but so should the pre-existing code here (the stuff that's now in
_updateWebkitTestUrls), so I was punting on that since we need to turn this
whole setup into a model object. I'll add a FIXME though to state this
explicitly.

https://codereview.chromium.org/416673003/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/ct-results-panel.html (right):

https://codereview.chromium.org/416673003/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/ct-results-panel.html:58: <template if="{{
failures[selected].testName != 'whole step failed' }}">
On 2014/07/29 16:38:17, abarth wrote:
> It's sad that 'whole step failed' is used as a magic value.  Can we make the
> testName null instead?

Done.