Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1933)

Unified Diff: Tools/GardeningServer/ui/ct-failure-card.html

Issue 413073004: Show non-Blink ranges in sheriff-o-matic. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/ui/ct-failure-analyzer.html ('k') | Tools/GardeningServer/ui/ct-failure-grouper.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-failure-card.html
diff --git a/Tools/GardeningServer/ui/ct-failure-card.html b/Tools/GardeningServer/ui/ct-failure-card.html
index e01bd8e26f43d7147c90d4312a03f9370882ade2..9d3cb24ca53c39ba539d2562f9efce589d60847e 100644
--- a/Tools/GardeningServer/ui/ct-failure-card.html
+++ b/Tools/GardeningServer/ui/ct-failure-card.html
@@ -55,14 +55,14 @@ found in the LICENSE file.
align-self: flex-start;
}
</style>
- <ct-builder-grid failures="{{failures}}"></ct-builder-grid>
+ <ct-builder-grid failures="{{ failures }}"></ct-builder-grid>
<div class="failure">
- <ct-test-list tests="{{failures}}"></ct-test-list>
- <ct-commit-list first="{{failures[0].newestPassingRevision + 1}}"
- last="{{failures[0].oldestFailingRevision}}"
- commits="{{commits}}"></ct-commit-list>
+ <ct-test-list tests="{{ failures }}"></ct-test-list>
+ <ct-commit-list first="{{ failures[0].lastPassingRevisions }}"
+ last="{{ failures[0].firstFailingRevisions }}"
+ commits="{{ commits }}"></ct-commit-list>
</div>
- <paper-button id="examine" on-tap="{{examine}}">Examine</paper-button>
+ <paper-button id="examine" on-tap="{{ examine }}">Examine</paper-button>
</template>
<script>
Polymer({
« no previous file with comments | « Tools/GardeningServer/ui/ct-failure-analyzer.html ('k') | Tools/GardeningServer/ui/ct-failure-grouper.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698