Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1853)

Unified Diff: Tools/GardeningServer/ui/ct-failure-analyzer.html

Issue 413073004: Show non-Blink ranges in sheriff-o-matic. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/ui/ct-commit-tests.html ('k') | Tools/GardeningServer/ui/ct-failure-card.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-failure-analyzer.html
diff --git a/Tools/GardeningServer/ui/ct-failure-analyzer.html b/Tools/GardeningServer/ui/ct-failure-analyzer.html
index 76498795cc86549b3dd234d87d054bf69d6d74e9..bbef2610d960b74949887d71acfeafa893556783 100644
--- a/Tools/GardeningServer/ui/ct-failure-analyzer.html
+++ b/Tools/GardeningServer/ui/ct-failure-analyzer.html
@@ -80,18 +80,9 @@ found in the LICENSE file.
}.bind(this));
var groupedFailures = [];
-
- var oldestFailingRevision, newestPassingRevision;
- // FIXME: This is a workaround for the backend's bogus data when the blink
- // regression ranges have no overlap.
- if (group.merged_last_passing && group.merged_first_failing.blink > group.merged_last_passing.blink) {
- oldestFailingRevision = Number(group.merged_first_failing.blink);
- newestPassingRevision = Number(group.merged_last_passing.blink);
- }
-
Object.keys(failuresByReason, function(failureKey, resultByBuilder) {
var failure = JSON.parse(failureKey);
- groupedFailures.push(new CTFailure(failure.step, failure.reason, resultByBuilder, oldestFailingRevision, newestPassingRevision));
+ groupedFailures.push(new CTFailure(failure.step, failure.reason, resultByBuilder, group.merged_first_failing, group.merged_last_passing));
});
// FIXME: Make this a model class intead of a dumb object.
« no previous file with comments | « Tools/GardeningServer/ui/ct-commit-tests.html ('k') | Tools/GardeningServer/ui/ct-failure-card.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698