Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 411243002: closure_linter: 2.3.4 => 2.3.14 (Closed)

Created:
6 years, 5 months ago by Dan Beam
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

closure_linter: 2.3.4 => 2.3.14 $ svn log -v http://closure-linter.googlecode.com/svn/trunk/ -r 15:28 # to see changelog TBR=tbreisacher@chromium.org BUG=393873 TEST=less invalid @suppress messages NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285242

Patch Set 1 #

Patch Set 2 : use library in correct way #

Patch Set 3 : remove checker #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4526 lines, -1129 lines) Patch
M chrome/browser/web_dev_style/js_checker.py View 1 2 3 chunks +4 lines, -6 lines 0 comments Download
M third_party/closure_linter/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/closure_linter/closure_linter/aliaspass.py View 1 chunk +222 lines, -0 lines 0 comments Download
A third_party/closure_linter/closure_linter/aliaspass_test.py View 1 chunk +162 lines, -0 lines 0 comments Download
M third_party/closure_linter/closure_linter/checker.py View 3 chunks +29 lines, -53 lines 0 comments Download
M third_party/closure_linter/closure_linter/checkerbase.py View 7 chunks +29 lines, -149 lines 0 comments Download
M third_party/closure_linter/closure_linter/closurizednamespacesinfo.py View 17 chunks +94 lines, -100 lines 0 comments Download
M third_party/closure_linter/closure_linter/closurizednamespacesinfo_test.py View 30 chunks +227 lines, -76 lines 0 comments Download
M third_party/closure_linter/closure_linter/common/error.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/closure_linter/closure_linter/common/filetestcase.py View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/closure_linter/closure_linter/common/tokenizer.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/closure_linter/closure_linter/common/tokens.py View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/closure_linter/closure_linter/common/tokens_test.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/closure_linter/closure_linter/ecmalintrules.py View 28 chunks +247 lines, -217 lines 0 comments Download
M third_party/closure_linter/closure_linter/ecmametadatapass.py View 11 chunks +73 lines, -15 lines 0 comments Download
M third_party/closure_linter/closure_linter/error_check.py View 3 chunks +7 lines, -2 lines 0 comments Download
M third_party/closure_linter/closure_linter/error_fixer.py View 15 chunks +108 lines, -25 lines 0 comments Download
A third_party/closure_linter/closure_linter/error_fixer_test.py View 1 chunk +57 lines, -0 lines 0 comments Download
M third_party/closure_linter/closure_linter/errorrecord.py View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/closure_linter/closure_linter/errorrules.py View 1 chunk +35 lines, -5 lines 0 comments Download
A third_party/closure_linter/closure_linter/errorrules_test.py View 1 chunk +117 lines, -0 lines 0 comments Download
M third_party/closure_linter/closure_linter/errors.py View 5 chunks +12 lines, -7 lines 0 comments Download
M third_party/closure_linter/closure_linter/fixjsstyle.py View 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/closure_linter/closure_linter/fixjsstyle_test.py View 10 chunks +220 lines, -73 lines 0 comments Download
M third_party/closure_linter/closure_linter/full_test.py View 5 chunks +13 lines, -8 lines 0 comments Download
M third_party/closure_linter/closure_linter/gjslint.py View 9 chunks +58 lines, -30 lines 0 comments Download
M third_party/closure_linter/closure_linter/indentation.py View 15 chunks +26 lines, -34 lines 0 comments Download
M third_party/closure_linter/closure_linter/javascriptlintrules.py View 23 chunks +289 lines, -84 lines 0 comments Download
M third_party/closure_linter/closure_linter/javascriptstatetracker.py View 5 chunks +47 lines, -6 lines 0 comments Download
A third_party/closure_linter/closure_linter/javascriptstatetracker_test.py View 1 chunk +278 lines, -0 lines 0 comments Download
M third_party/closure_linter/closure_linter/javascripttokenizer.py View 5 chunks +133 lines, -123 lines 0 comments Download
M third_party/closure_linter/closure_linter/not_strict_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/closure_linter/closure_linter/requireprovidesorter.py View 10 chunks +74 lines, -20 lines 0 comments Download
M third_party/closure_linter/closure_linter/requireprovidesorter_test.py View 2 chunks +89 lines, -8 lines 0 comments Download
A third_party/closure_linter/closure_linter/runner.py View 1 chunk +198 lines, -0 lines 0 comments Download
A third_party/closure_linter/closure_linter/runner_test.py View 1 chunk +101 lines, -0 lines 0 comments Download
A third_party/closure_linter/closure_linter/scopeutil.py View 1 chunk +172 lines, -0 lines 0 comments Download
A third_party/closure_linter/closure_linter/scopeutil_test.py View 1 chunk +210 lines, -0 lines 0 comments Download
M third_party/closure_linter/closure_linter/statetracker.py View 36 chunks +268 lines, -60 lines 0 comments Download
A third_party/closure_linter/closure_linter/statetracker_test.py View 1 chunk +122 lines, -0 lines 0 comments Download
A third_party/closure_linter/closure_linter/strict_test.py View 1 chunk +68 lines, -0 lines 0 comments Download
A third_party/closure_linter/closure_linter/testutil.py View 1 chunk +91 lines, -0 lines 0 comments Download
M third_party/closure_linter/closure_linter/tokenutil.py View 4 chunks +322 lines, -2 lines 0 comments Download
A third_party/closure_linter/closure_linter/tokenutil_test.py View 1 chunk +289 lines, -0 lines 0 comments Download
M third_party/closure_linter/setup.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Dan Beam
6 years, 5 months ago (2014-07-24 04:37:48 UTC) #1
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 5 months ago (2014-07-24 04:37:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/411243002/1
6 years, 5 months ago (2014-07-24 04:39:15 UTC) #3
Dan Beam
The CQ bit was unchecked by dbeam@chromium.org
6 years, 5 months ago (2014-07-24 05:48:26 UTC) #4
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 5 months ago (2014-07-24 06:24:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/411243002/40001
6 years, 5 months ago (2014-07-24 06:28:12 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 08:16:32 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 08:21:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/82011)
6 years, 5 months ago (2014-07-24 08:21:31 UTC) #9
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 5 months ago (2014-07-24 13:21:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/411243002/40001
6 years, 5 months ago (2014-07-24 13:27:02 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 14:05:27 UTC) #12
Message was sent while issue was closed. 
Change committed as 285242

Powered by Google App Engine
This is Rietveld 408576698