closure_linter: 2.3.4 => 2.3.14

chrome/browser/web_dev_style/js_checker.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Presubmit script for Chromium JS resources.
 
 See chrome/browser/PRESUBMIT.py
 """
 
 class JSChecker(object):
@@ skipping 127 matching lines @@
       gflags_path = self.input_api.os_path.join(
           self.input_api.change.RepositoryRoot(),
           "third_party",
           "python_gflags")
 
       sys.path.insert(0, closure_linter_path)
       sys.path.insert(0, gflags_path)
 
       warnings.filterwarnings('ignore', category=DeprecationWarning)
 
-      from closure_linter import checker, errors
+      from closure_linter import errors, runner
       from closure_linter.common import errorhandler
 
     finally:
       sys.path = old_path
       warnings.filters = old_filters
 
     class ErrorHandlerImpl(errorhandler.ErrorHandler):
       """Filters out errors that don't apply to Chromium JavaScript code."""
 
       def __init__(self, re):
@@ skipping 24 matching lines @@
 
         # Ignore missing spaces before "(" until Promise#catch issue is solved.
         # http://crbug.com/338301
         if (error.code == errors.MISSING_SPACE and error.token.string == '(' and
            'catch(' in error.token.line):
           return False
 
         return not is_grit_statement and error.code not in [
             errors.COMMA_AT_END_OF_LITERAL,
             errors.JSDOC_ILLEGAL_QUESTION_WITH_PIPE,
-            errors.JSDOC_TAG_DESCRIPTION_ENDS_WITH_INVALID_CHARACTER,
             errors.LINE_TOO_LONG,
             errors.MISSING_JSDOC_TAG_THIS,
         ]
 
     results = []
 
     affected_files = self.input_api.change.AffectedFiles(
         file_filter=self.file_filter,
         include_deletes=False)
     affected_js_files = filter(lambda f: f.LocalPath().endswith('.js'),
@@ skipping 10 matching lines @@
             self.ChromeSendCheck(i, line),
             self.ConstCheck(i, line),
             self.GetElementByIdCheck(i, line),
             self.InheritDocCheck(i, line),
             self.WrapperTypeCheck(i, line),
             self.VarNameCheck(i, line),
         ])
 
       # Use closure_linter to check for several different errors
       error_handler = ErrorHandlerImpl(self.input_api.re)
-      js_checker = checker.JavaScriptStyleChecker(error_handler)
-      js_checker.Check(self.input_api.os_path.join(
-          self.input_api.change.RepositoryRoot(),
-          f.LocalPath()))
+      file_to_check = self.input_api.os_path.join(
+          self.input_api.change.RepositoryRoot(), f.LocalPath())
+      runner.Run(file_to_check, error_handler)
 
       for error in error_handler.GetErrors():
         highlight = self.error_highlight(
             error.token.start_index, error.token.length)
         error_msg = '  line %d: E%04d: %s\n%s\n%s' % (
             error.token.line_number,
             error.code,
             error.message,
             error.token.line.rstrip(),
             highlight)
         error_lines.append(error_msg)
 
       if error_lines:
         error_lines = [
             'Found JavaScript style violations in %s:' %
             f.LocalPath()] + error_lines
         results.append(self._makeErrorOrWarning(
             '\n'.join(error_lines), f.AbsoluteLocalPath()))
 
     if results:
       results.append(self.output_api.PresubmitNotifyResult(
           'See the JavaScript style guide at '
           'http://www.chromium.org/developers/web-development-style-guide'
           '#TOC-JavaScript and if you have any feedback about the JavaScript '
           'PRESUBMIT check, contact tbreisacher@chromium.org or '
           'dbeam@chromium.org'))
 
     return results