Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: third_party/closure_linter/closure_linter/errorrules.py

Issue 411243002: closure_linter: 2.3.4 => 2.3.14 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove checker Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/closure_linter/closure_linter/errorrules.py
diff --git a/third_party/closure_linter/closure_linter/errorrules.py b/third_party/closure_linter/closure_linter/errorrules.py
index afb6fa9606ca5b908d9031913d44858d78a31ac7..b1b72aab6dabdc895614859e53e2cb957d8fafc9 100755
--- a/third_party/closure_linter/closure_linter/errorrules.py
+++ b/third_party/closure_linter/closure_linter/errorrules.py
@@ -25,18 +25,48 @@ from closure_linter import errors
FLAGS = flags.FLAGS
flags.DEFINE_boolean('jsdoc', True,
'Whether to report errors for missing JsDoc.')
+flags.DEFINE_list('disable', None,
+ 'Disable specific error. Usage Ex.: gjslint --disable 1,'
+ '0011 foo.js.')
+flags.DEFINE_integer('max_line_length', 80, 'Maximum line length allowed '
+ 'without warning.', lower_bound=1)
+
+disabled_error_nums = None
+
+
+def GetMaxLineLength():
+ """Returns allowed maximum length of line.
+
+ Returns:
+ Length of line allowed without any warning.
+ """
+ return FLAGS.max_line_length
def ShouldReportError(error):
"""Whether the given error should be reported.
-
+
Returns:
- True for all errors except missing documentation errors. For these,
- it returns the value of the jsdoc flag.
+ True for all errors except missing documentation errors and disabled
+ errors. For missing documentation, it returns the value of the
+ jsdoc flag.
"""
- return FLAGS.jsdoc or error not in (
+ global disabled_error_nums
+ if disabled_error_nums is None:
+ disabled_error_nums = []
+ if FLAGS.disable:
+ for error_str in FLAGS.disable:
+ error_num = 0
+ try:
+ error_num = int(error_str)
+ except ValueError:
+ pass
+ disabled_error_nums.append(error_num)
+
+ return ((FLAGS.jsdoc or error not in (
errors.MISSING_PARAMETER_DOCUMENTATION,
errors.MISSING_RETURN_DOCUMENTATION,
errors.MISSING_MEMBER_DOCUMENTATION,
errors.MISSING_PRIVATE,
- errors.MISSING_JSDOC_TAG_THIS)
+ errors.MISSING_JSDOC_TAG_THIS)) and
+ (not FLAGS.disable or error not in disabled_error_nums))
« no previous file with comments | « third_party/closure_linter/closure_linter/errorrecord.py ('k') | third_party/closure_linter/closure_linter/errorrules_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698