Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: third_party/closure_linter/closure_linter/strict_test.py

Issue 411243002: closure_linter: 2.3.4 => 2.3.14 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove checker Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/closure_linter/closure_linter/strict_test.py
diff --git a/third_party/closure_linter/closure_linter/strict_test.py b/third_party/closure_linter/closure_linter/strict_test.py
new file mode 100644
index 0000000000000000000000000000000000000000..75044e8a20bc33671fd529cae8a3b7b02695b66d
--- /dev/null
+++ b/third_party/closure_linter/closure_linter/strict_test.py
@@ -0,0 +1,68 @@
+#!/usr/bin/env python
+# Copyright 2013 The Closure Linter Authors. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS-IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""Tests for gjslint --strict.
+
+Tests errors that can be thrown by gjslint when in strict mode.
+"""
+
+
+
+import unittest
+
+import gflags as flags
+import unittest as googletest
+
+from closure_linter import errors
+from closure_linter import runner
+from closure_linter.common import erroraccumulator
+
+flags.FLAGS.strict = True
+
+
+class StrictTest(unittest.TestCase):
+ """Tests scenarios where strict generates warnings."""
+
+ def testUnclosedString(self):
+ """Tests warnings are reported when nothing is disabled.
+
+ b/11450054.
+ """
+ original = [
+ 'bug = function() {',
+ ' (\'foo\'\');',
+ '};',
+ '',
+ ]
+
+ expected = [errors.FILE_DOES_NOT_PARSE, errors.MULTI_LINE_STRING,
+ errors.FILE_IN_BLOCK]
+ self._AssertErrors(original, expected)
+
+ def _AssertErrors(self, original, expected_errors):
+ """Asserts that the error fixer corrects original to expected."""
+
+ # Trap gjslint's output parse it to get messages added.
+ error_accumulator = erroraccumulator.ErrorAccumulator()
+ runner.Run('testing.js', error_accumulator, source=original)
+ error_nums = [e.code for e in error_accumulator.GetErrors()]
+
+ error_nums.sort()
+ expected_errors.sort()
+ self.assertListEqual(error_nums, expected_errors)
+
+if __name__ == '__main__':
+ googletest.main()
+
« no previous file with comments | « third_party/closure_linter/closure_linter/statetracker_test.py ('k') | third_party/closure_linter/closure_linter/testutil.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698