Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6586)

Unified Diff: chrome/browser/web_dev_style/js_checker.py

Issue 411243002: closure_linter: 2.3.4 => 2.3.14 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove checker Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/closure_linter/README.chromium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_dev_style/js_checker.py
diff --git a/chrome/browser/web_dev_style/js_checker.py b/chrome/browser/web_dev_style/js_checker.py
index 0e224aa84651ff31f2d43d225ccfcf192b6d61ac..ab0769134ec8bf60d5d50288dc1871d38fcd0093 100644
--- a/chrome/browser/web_dev_style/js_checker.py
+++ b/chrome/browser/web_dev_style/js_checker.py
@@ -145,7 +145,7 @@ class JSChecker(object):
warnings.filterwarnings('ignore', category=DeprecationWarning)
- from closure_linter import checker, errors
+ from closure_linter import errors, runner
from closure_linter.common import errorhandler
finally:
@@ -190,7 +190,6 @@ class JSChecker(object):
return not is_grit_statement and error.code not in [
errors.COMMA_AT_END_OF_LITERAL,
errors.JSDOC_ILLEGAL_QUESTION_WITH_PIPE,
- errors.JSDOC_TAG_DESCRIPTION_ENDS_WITH_INVALID_CHARACTER,
errors.LINE_TOO_LONG,
errors.MISSING_JSDOC_TAG_THIS,
]
@@ -221,10 +220,9 @@ class JSChecker(object):
# Use closure_linter to check for several different errors
error_handler = ErrorHandlerImpl(self.input_api.re)
- js_checker = checker.JavaScriptStyleChecker(error_handler)
- js_checker.Check(self.input_api.os_path.join(
- self.input_api.change.RepositoryRoot(),
- f.LocalPath()))
+ file_to_check = self.input_api.os_path.join(
+ self.input_api.change.RepositoryRoot(), f.LocalPath())
+ runner.Run(file_to_check, error_handler)
for error in error_handler.GetErrors():
highlight = self.error_highlight(
« no previous file with comments | « no previous file | third_party/closure_linter/README.chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698